Re: [v4] net/gve: check driver compatibility

2023-05-31 Thread Rushil Gupta
http://patchwork.dpdk.org/project/dpdk/patch/20230524171324.2072742-1-rush...@google.com/ Does this look good to you? On Wed, May 24, 2023 at 10:14 AM Rushil Gupta wrote: > > As noted from spec: "Some commands require an additional dma memory > region to be passed to the device" > We are passing

Re: [v4] net/gve: check driver compatibility

2023-05-24 Thread Rushil Gupta
As noted from spec: "Some commands require an additional dma memory region to be passed to the device" We are passing virtual addresses to devices (please look at link-speed and describe-device adminq commands): describe device: https://github.com/DPDK/dpdk/blob/main/drivers/net/gve/base/gve_adminq

Re: [v4] net/gve: check driver compatibility

2023-05-23 Thread Ferruh Yigit
On 5/19/2023 9:46 PM, Rushil Gupta wrote: > diff --git a/drivers/net/gve/base/gve_osdep.h > b/drivers/net/gve/base/gve_osdep.h > index abf3d379ae..5e8ae1eac6 100644 > --- a/drivers/net/gve/base/gve_osdep.h > +++ b/drivers/net/gve/base/gve_osdep.h > @@ -21,9 +21,14 @@ > #include > #include > #

Re: [v4] net/gve: check driver compatibility

2023-05-23 Thread Ferruh Yigit
On 5/22/2023 4:45 PM, Rushil Gupta wrote: > 1. This is the excerpt from the google's virtual nic spec:  > "In addition to the device-owned register file, vector table, and > doorbells, the gVNIC device uses *DMA* (which in most cases amounts to > ordinary memory access by host software since we're

Re: [v4] net/gve: check driver compatibility

2023-05-22 Thread Rushil Gupta
1. This is the excerpt from the google's virtual nic spec: "In addition to the device-owned register file, vector table, and doorbells, the gVNIC device uses *DMA* (which in most cases amounts to ordinary memory access by host software since we're dealing with a virtual device, but guests must assu

Re: [v4] net/gve: check driver compatibility

2023-05-22 Thread Ferruh Yigit
On 5/19/2023 9:46 PM, Rushil Gupta wrote: > +static int > +gve_verify_driver_compatibility(struct gve_priv *priv) > +{ > + const struct rte_memzone *driver_info_mem; > + struct gve_driver_info *driver_info; > + int err; > + > + driver_info_mem = > rte_memzone_reserve_aligned("verif

Re: [v4] net/gve: check driver compatibility

2023-05-20 Thread Rushil Gupta
We are not validating anything. This is for our internal analysis and product requirements. On Fri, May 19, 2023 at 1:56 PM Stephen Hemminger < step...@networkplumber.org> wrote: > On Fri, 19 May 2023 13:46:18 -0700 > Rushil Gupta wrote: > > > +#include > > > > #include "../gve_logs.h" > > > >

Re: [v4] net/gve: check driver compatibility

2023-05-19 Thread Stephen Hemminger
On Fri, 19 May 2023 13:46:18 -0700 Rushil Gupta wrote: > +#include > > #include "../gve_logs.h" > > +#ifdef __linux__ > +#include > +#endif > + > typedef uint8_t u8; > typedef uint16_t u16; > typedef uint32_t u32; > @@ -73,6 +78,12 @@ typedef rte_iova_t dma_addr_t; > > #define msleep

[v4] net/gve: check driver compatibility

2023-05-19 Thread Rushil Gupta
Change gve_driver_info fields to report DPDK as OS type and DPDK RTE version as OS version, reserving driver_version fields for GVE driver version based on features. Signed-off-by: Rushil Gupta Signed-off-by: Joshua Washington Signed-off-by: Junfeng Guo Signed-off-by: Jeroen de Borst --- driv

[v4] net/gve: check driver compatibility

2023-05-19 Thread Rushil Gupta
Change gve_driver_info fields to report DPDK as OS type and DPDK RTE version as OS version, reserving driver_version fields for GVE driver version based on features. Signed-off-by: Rushil Gupta Signed-off-by: Joshua Washington Signed-off-by: Junfeng Guo Signed-off-by: Jeroen de Borst --- driv