Re: [dpdk-dev] rte_mbuf library likely()/unlikely()

2018-07-24 Thread Wiles, Keith
> On Jul 24, 2018, at 6:31 AM, Van Haaren, Harry > wrote: > >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Morten Brørup >> Sent: Tuesday, July 24, 2018 9:14 AM >> To: Olivier Matz ; Wiles, Keith >> >> Cc: Honnappa Nagarahalli ; dev@dpdk.

Re: [dpdk-dev] rte_mbuf library likely()/unlikely()

2018-07-24 Thread Van Haaren, Harry
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Morten Brørup > Sent: Tuesday, July 24, 2018 9:14 AM > To: Olivier Matz ; Wiles, Keith > > Cc: Honnappa Nagarahalli ; dev@dpdk.org > Subject: Re: [dpdk-dev] rte_mbuf library likely()/unlikely() > > > -Original

Re: [dpdk-dev] rte_mbuf library likely()/unlikely()

2018-07-24 Thread Morten Brørup
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Olivier Matz > Sent: Tuesday, July 24, 2018 9:29 AM > > Hi, > > On Mon, Jul 23, 2018 at 10:40:03PM +, Wiles, Keith wrote: > > > > > > > On Jul 23, 2018, at 2:09 PM, Morten Brørup > wrote: > > > > > > I haven'

Re: [dpdk-dev] rte_mbuf library likely()/unlikely()

2018-07-24 Thread Olivier Matz
Hi, On Mon, Jul 23, 2018 at 10:40:03PM +, Wiles, Keith wrote: > > > > On Jul 23, 2018, at 2:09 PM, Morten Brørup > > wrote: > > > > I haven't performance tested, but they are compiler branch prediction hints > > pointing out the most likely execution path, so I expect them to have a > >

Re: [dpdk-dev] rte_mbuf library likely()/unlikely()

2018-07-23 Thread Wiles, Keith
>> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Honnappa Nagarahalli >> Sent: Monday, July 23, 2018 7:52 PM >> To: Morten Brørup; Olivier Matz >> Cc: dev@dpdk.org >> Subject: Re: [dpdk-dev] rte_mbuf library likely()/unlikely() >> >> Do you se

Re: [dpdk-dev] rte_mbuf library likely()/unlikely()

2018-07-23 Thread Stephen Hemminger
On Mon, 23 Jul 2018 20:59:29 +0200 Morten Brørup wrote: > > -Original Message- > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Monday, July 23, 2018 7:38 PM > > To: Morten Brørup > > Cc: Olivier Matz; dev@dpdk.org > > Subj

Re: [dpdk-dev] rte_mbuf library likely()/unlikely()

2018-07-23 Thread Morten Brørup
To: Morten Brørup; Olivier Matz > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] rte_mbuf library likely()/unlikely() > > Do you see any performance improvements with these changes? > > -Original Message- > From: dev On Behalf Of Morten Brørup > Sent: Monday, July

Re: [dpdk-dev] rte_mbuf library likely()/unlikely()

2018-07-23 Thread Morten Brørup
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Monday, July 23, 2018 7:38 PM > To: Morten Brørup > Cc: Olivier Matz; dev@dpdk.org > Subject: Re: [dpdk-dev] rte_mbuf library likely()/unlikely() > > On Mon, 23 Jul 2018

Re: [dpdk-dev] rte_mbuf library likely()/unlikely()

2018-07-23 Thread Honnappa Nagarahalli
Do you see any performance improvements with these changes? -Original Message- From: dev On Behalf Of Morten Brørup Sent: Monday, July 23, 2018 8:54 AM To: Olivier Matz Cc: dev@dpdk.org Subject: [dpdk-dev] rte_mbuf library likely()/unlikely() Hi Olivier, I noticed that

Re: [dpdk-dev] rte_mbuf library likely()/unlikely()

2018-07-23 Thread Stephen Hemminger
On Mon, 23 Jul 2018 15:53:42 +0200 Morten Brørup wrote: > Hi Olivier, > > > > I noticed that __rte_pktmbuf_read() could do with an unlikely(), so I went > through the entire library. Here are my suggested modifications. > > > > > > diff -bu rte_mbuf.c.orig rte_mbuf.c > > --- rte_mbuf

[dpdk-dev] rte_mbuf library likely()/unlikely()

2018-07-23 Thread Morten Brørup
Hi Olivier, I noticed that __rte_pktmbuf_read() could do with an unlikely(), so I went through the entire library. Here are my suggested modifications. diff -bu rte_mbuf.c.orig rte_mbuf.c --- rte_mbuf.c.orig 2018-07-23 15:13:22.0 +0200 +++ rte_mbuf.c 2018-07-23 15:32:53.0