Re: [dpdk-dev] librte_net/rte_ip.h checksum functions question

2017-07-20 Thread Ido Barnea (ibarnea)
Sounds fine to me. Are you planning to add this, or you want me to do it? On 20/07/2017, 12:09 PM, "Olivier Matz" wrote: >Hi Ido, > >On Tue, 18 Jul 2017 12:18:20 +, "Ido Barnea (ibarnea)" >wrote: >> Hi, >> Is it intentional that rte_ipv4_phdr_cksum and others in this file assume >> tha

Re: [dpdk-dev] librte_net/rte_ip.h checksum functions question

2017-07-20 Thread Olivier Matz
Hi Ido, On Tue, 18 Jul 2017 12:18:20 +, "Ido Barnea (ibarnea)" wrote: > Hi, > Is it intentional that rte_ipv4_phdr_cksum and others in this file assume > that ipv4 header is sizeof(struct ipv4_hdr), actually assuming that there are > no IPv4 options? > If not, I would like to submit a patc

[dpdk-dev] librte_net/rte_ip.h checksum functions question

2017-07-18 Thread Ido Barnea (ibarnea)
Hi, Is it intentional that rte_ipv4_phdr_cksum and others in this file assume that ipv4 header is sizeof(struct ipv4_hdr), actually assuming that there are no IPv4 options? If not, I would like to submit a patch changing that. Something in the line of: sizeof(struct ipv4_hdr) changes to ipv4_hdr-