Re: [dpdk-dev] i40e igb_uio: reset pci on process exit

2017-05-29 Thread Gregory Etelson
PMD already resets PCI during initialization. In my patch, exiting process forced to release it's resources On Monday, 29 May 2017 14:01:48 IDT Shijith Thotton wrote: > On Mon, May 29, 2017 at 01:01:06PM +0300, Gregory Etelson wrote: > >I still have to support Red Hat 6.x. These system do not

Re: [dpdk-dev] i40e igb_uio: reset pci on process exit

2017-05-29 Thread Shijith Thotton
On Mon, May 29, 2017 at 01:01:06PM +0300, Gregory Etelson wrote: >I still have to support Red Hat 6.x. These system do not have VFIO > >IGB_UIO is the only option there. > >Also, there was a discussion that claimed IGB_UIO has better performance >than VFIO. > >http://dpdk.org

Re: [dpdk-dev] i40e igb_uio: reset pci on process exit

2017-05-29 Thread Gregory Etelson
I still have to support Red Hat 6.x. These system do not have VFIO IGB_UIO is the only option there. Also, there was a discussion that claimed IGB_UIO has better performance than VFIO. http://dpdk.org/ml/archives/dev/2014-August/004609.html Regards, Gregory On Monday, 29 May 2017 12:48:59 ID

Re: [dpdk-dev] i40e igb_uio: reset pci on process exit

2017-05-29 Thread Shijith Thotton
On Fri, May 26, 2017 at 07:14:55PM +0300, Gregory Etelson wrote: >I did not look into VFIO driver yet > > > >Regards, > >Gregory > > > >On Friday, 26 May 2017 18:53:21 IDT Stephen Hemminger wrote: > >> On Fri, 26 May 2017 09:17:33 +0300 > >> Gregory Etelson

Re: [dpdk-dev] i40e igb_uio: reset pci on process exit

2017-05-26 Thread Gregory Etelson
I did not look into VFIO driver yet Regards, Gregory On Friday, 26 May 2017 18:53:21 IDT Stephen Hemminger wrote: > On Fri, 26 May 2017 09:17:33 +0300 > Gregory Etelson wrote: > > > Thank you. > > > > Regards, > > Gregory > > > > On Friday, 26 May 2017 09:05:11 IDT Shijith Thotton wrote: > >

Re: [dpdk-dev] i40e igb_uio: reset pci on process exit

2017-05-26 Thread Stephen Hemminger
On Fri, 26 May 2017 09:17:33 +0300 Gregory Etelson wrote: > Thank you. > > Regards, > Gregory > > On Friday, 26 May 2017 09:05:11 IDT Shijith Thotton wrote: > > On Fri, May 26, 2017 at 07:30:58AM +0300, Gregory Etelson wrote: > > > > Hi Gregory, > > > > The patch is useful for LiquidIO PMD as

Re: [dpdk-dev] i40e igb_uio: reset pci on process exit

2017-05-25 Thread Gregory Etelson
Thank you. Regards, Gregory On Friday, 26 May 2017 09:05:11 IDT Shijith Thotton wrote: > On Fri, May 26, 2017 at 07:30:58AM +0300, Gregory Etelson wrote: > > Hi Gregory, > > The patch is useful for LiquidIO PMD as we can avoid VF FLR request to > PF. One comment inline.. > > [..] > > > > > >

Re: [dpdk-dev] i40e igb_uio: reset pci on process exit

2017-05-25 Thread Shijith Thotton
On Fri, May 26, 2017 at 07:30:58AM +0300, Gregory Etelson wrote: Hi Gregory, The patch is useful for LiquidIO PMD as we can avoid VF FLR request to PF. One comment inline.. [..] > > > > > > +static int > > > +igbuio_pci_release(struct uio_info *info, struct inode *inode) > > > +{ > > > +

Re: [dpdk-dev] i40e igb_uio: reset pci on process exit

2017-05-25 Thread Gregory Etelson
Hello, This patch introduces idea I would like to implement in igb_uio driver However, I would like to get hardware experts confirmation. If the procedure correct I'll submit proper patch Regards, Gregory On Thursday, 25 May 2017 21:42:42 IDT Stephen Hemminger wrote: > On Wed, 24 May 2017 14:22

Re: [dpdk-dev] i40e igb_uio: reset pci on process exit

2017-05-25 Thread Stephen Hemminger
On Wed, 24 May 2017 14:22:11 +0300 Gregory Etelson wrote: > > +static int > +igbuio_pci_release(struct uio_info *info, struct inode *inode) > +{ > + int ret; > + struct rte_uio_pci_dev *udev = info->priv; > + struct pci_dev *dev = udev->pdev; > + ret = __pci_reset_functi

[dpdk-dev] i40e igb_uio: reset pci on process exit

2017-05-24 Thread Gregory Etelson
Hello, My tests show if DPDK process attached to i40e VF through igb_uio exists without calling rte_eth_dev_close() then new instance attached to that VF could experience IO failures. I came up with the following patch to ensure igb_uio will always reset PCI on process exit. However, I would l