Re: [dpdk-dev] Which counters are set by rte_eth_stats_get

2018-11-13 Thread Tom Barbette
> For others, if the driver has no places it allocates mbufs or drops packets > in the driver I see no > reason that the driver needs to do anything with those fields. I understand. I'll fix the driver I use then. There may still be some counters that should increase but are not reported by hard

Re: [dpdk-dev] Which counters are set by rte_eth_stats_get

2018-11-09 Thread Stephen Hemminger
On Fri, 09 Nov 2018 09:38:46 +0100 Thomas Monjalon wrote: > 09/11/2018 09:28, Tom Barbette: > > Hi ethdev maintainers, > > > > > > Support of drivers for the fields in rte_eth_stats is a bit random, and > > never mentioned in the doc. A quick survey showed me : > > > > > > ipackets : impleme

Re: [dpdk-dev] Which counters are set by rte_eth_stats_get

2018-11-09 Thread Tom Barbette
> The other option would be to push for implementing all basic stats > in all drivers, and consider an unimplemented stat as a bug. It may be impossible in some cases. I think imissed is not even reported by hardware for mlx5 cards. Only an aggregate for all queues. I'll add a "uint64_t stats_ca

Re: [dpdk-dev] Which counters are set by rte_eth_stats_get

2018-11-09 Thread Thomas Monjalon
09/11/2018 09:28, Tom Barbette: > Hi ethdev maintainers, > > > Support of drivers for the fields in rte_eth_stats is a bit random, and never > mentioned in the doc. A quick survey showed me : > > > ipackets : implemented by all drivers > ibytes : all except null, ring > ierror : all except af_

[dpdk-dev] Which counters are set by rte_eth_stats_get

2018-11-09 Thread Tom Barbette
Hi ethdev maintainers, Support of drivers for the fields in rte_eth_stats is a bit random, and never mentioned in the doc. A quick survey showed me : ipackets : implemented by all drivers ibytes : all except null, ring ierror : all except af_packet, ark, avf, axgbe, fm10k, kni, null, pcap, rin