Re: [dpdk-dev] Using _XOPEN_SOURCE macros may break builds on FreeBSD

2019-05-14 Thread Ananyev, Konstantin
Hi Adrien, > On Tue, May 14, 2019 at 08:58:42AM +, Smoczynski, MarcinX wrote: > > > > Hey Konstantin, > > > > > > > > On Mon, May 13, 2019 at 10:49:00AM +, Ananyev, Konstantin wrote: > > > > > Hi Adrien, > > > > > > > > > > > > > > > > > On Mon, May 13, 2019 at 09:51:24AM +, Smoczynski

Re: [dpdk-dev] Using _XOPEN_SOURCE macros may break builds on FreeBSD

2019-05-14 Thread Adrien Mazarguil
On Tue, May 14, 2019 at 08:58:42AM +, Smoczynski, MarcinX wrote: > > > Hey Konstantin, > > > > > > On Mon, May 13, 2019 at 10:49:00AM +, Ananyev, Konstantin wrote: > > > > Hi Adrien, > > > > > > > > > > > > > > On Mon, May 13, 2019 at 09:51:24AM +, Smoczynski, MarcinX > > wrote: > > > >

Re: [dpdk-dev] Using _XOPEN_SOURCE macros may break builds on FreeBSD

2019-05-14 Thread Smoczynski, MarcinX
> > Hey Konstantin, > > > > On Mon, May 13, 2019 at 10:49:00AM +, Ananyev, Konstantin wrote: > > > Hi Adrien, > > > > > > > > > > > On Mon, May 13, 2019 at 09:51:24AM +, Smoczynski, MarcinX > wrote: > > > > > 10/05/2019 20:17, Thomas Monjalon: > > > > > > 10/05/2019 19:14, Smoczynski, Marci

Re: [dpdk-dev] Using _XOPEN_SOURCE macros may break builds on FreeBSD

2019-05-13 Thread Ananyev, Konstantin
> Hey Konstantin, > > On Mon, May 13, 2019 at 10:49:00AM +, Ananyev, Konstantin wrote: > > Hi Adrien, > > > > > > > > On Mon, May 13, 2019 at 09:51:24AM +, Smoczynski, MarcinX wrote: > > > > 10/05/2019 20:17, Thomas Monjalon: > > > > > 10/05/2019 19:14, Smoczynski, MarcinX: > > > > >

Re: [dpdk-dev] Using _XOPEN_SOURCE macros may break builds on FreeBSD

2019-05-13 Thread Adrien Mazarguil
Hey Konstantin, On Mon, May 13, 2019 at 10:49:00AM +, Ananyev, Konstantin wrote: > Hi Adrien, > > > > > On Mon, May 13, 2019 at 09:51:24AM +, Smoczynski, MarcinX wrote: > > > 10/05/2019 20:17, Thomas Monjalon: > > > > 10/05/2019 19:14, Smoczynski, MarcinX: > > > > > To summarize we have

Re: [dpdk-dev] Using _XOPEN_SOURCE macros may break builds on FreeBSD

2019-05-13 Thread Ananyev, Konstantin
Hi Adrien, > > On Mon, May 13, 2019 at 09:51:24AM +, Smoczynski, MarcinX wrote: > > 10/05/2019 20:17, Thomas Monjalon: > > > 10/05/2019 19:14, Smoczynski, MarcinX: > > > > To summarize we have different visibility sets for Linux and BSD > > > > when using XOPEN_SOURCE or POSIX_C_SOURCE explic

Re: [dpdk-dev] Using _XOPEN_SOURCE macros may break builds on FreeBSD

2019-05-13 Thread Adrien Mazarguil
On Mon, May 13, 2019 at 09:51:24AM +, Smoczynski, MarcinX wrote: > 10/05/2019 20:17, Thomas Monjalon: > > 10/05/2019 19:14, Smoczynski, MarcinX: > > > To summarize we have different visibility sets for Linux and BSD > > > when using XOPEN_SOURCE or POSIX_C_SOURCE explicitly. To overcome > > >

Re: [dpdk-dev] Using _XOPEN_SOURCE macros may break builds on FreeBSD

2019-05-13 Thread Smoczynski, MarcinX
10/05/2019 20:17, Thomas Monjalon: > 10/05/2019 19:14, Smoczynski, MarcinX: > > To summarize we have different visibility sets for Linux and BSD > > when using XOPEN_SOURCE or POSIX_C_SOURCE explicitly. To overcome > > this situation we can either remove problematic XOPEN macros from > > mk/meso

Re: [dpdk-dev] Using _XOPEN_SOURCE macros may break builds on FreeBSD

2019-05-10 Thread Thomas Monjalon
re-send with fixed Cc 10/05/2019 20:17, Thomas Monjalon: > 10/05/2019 19:14, Smoczynski, MarcinX: > > To summarize we have different visibility sets for Linux and BSD when using > > XOPEN_SOURCE or POSIX_C_SOURCE explicitly. To overcome this situation we can > > either remove problematic XOPEN mac

Re: [dpdk-dev] Using _XOPEN_SOURCE macros may break builds on FreeBSD

2019-05-10 Thread Thomas Monjalon
10/05/2019 19:14, Smoczynski, MarcinX: > To summarize we have different visibility sets for Linux and BSD when using > XOPEN_SOURCE or POSIX_C_SOURCE explicitly. To overcome this situation we can > either remove problematic XOPEN macros from mk/meson rules > (drivers/net/failsafe, > drivers/net/ml

[dpdk-dev] Using _XOPEN_SOURCE macros may break builds on FreeBSD

2019-05-10 Thread Smoczynski, MarcinX
Hi. One of my patches submitted this week is breaking build on BSD systems. I dug deeper and found out that it's because I'm using IPPROTO_* macros from in a header (rte_ip.h) which is included in the driver which uses _XOPEN_SOURCE definition in its Makefile/meson.build. On Linux and glibc this