[dpdk-dev] Added Spinlock to l3fwd-vf example to prevent race conditioning

2014-12-11 Thread Thomas Monjalon
> > Signed-off-by: Daniel Mrzyglod > > Acked-by: Neil Horman Applied Thanks -- Thomas

[dpdk-dev] Added Spinlock to l3fwd-vf example to prevent race conditioning

2014-12-10 Thread Neil Horman
On Wed, Dec 10, 2014 at 03:38:37PM -0800, Stephen Hemminger wrote: > On Wed, 10 Dec 2014 11:16:46 -0500 > Neil Horman wrote: > > > This really seems like a false savings to me. If an application intends to > > use > > multiple processes (which by all rights it seems like the use case that the

[dpdk-dev] Added Spinlock to l3fwd-vf example to prevent race conditioning

2014-12-10 Thread Mrzyglod, DanielX T
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson > Sent: Wednesday, December 10, 2014 3:55 PM > To: Neil Horman > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] Added Spinlock to l3fwd-vf example to prevent race > con

[dpdk-dev] Added Spinlock to l3fwd-vf example to prevent race conditioning

2014-12-10 Thread Stephen Hemminger
On Wed, 10 Dec 2014 11:16:46 -0500 Neil Horman wrote: > This really seems like a false savings to me. If an application intends to > use > multiple processes (which by all rights it seems like the use case that the > dpdk > is mostly designed for) then you need locking one way or another, and

[dpdk-dev] Added Spinlock to l3fwd-vf example to prevent race conditioning

2014-12-10 Thread Bruce Richardson
On Wed, Dec 10, 2014 at 09:47:45AM -0500, Neil Horman wrote: > On Wed, Dec 10, 2014 at 08:18:36AM +, Wodkowski, PawelX wrote: > > > Though, that said, doesn't it seem to anyone else like serialization of > > > enqueue > > > to a port should be the responsibility of the library, not the > > >

[dpdk-dev] Added Spinlock to l3fwd-vf example to prevent race conditioning

2014-12-10 Thread Neil Horman
On Wed, Dec 10, 2014 at 02:54:56PM +, Bruce Richardson wrote: > On Wed, Dec 10, 2014 at 09:47:45AM -0500, Neil Horman wrote: > > On Wed, Dec 10, 2014 at 08:18:36AM +, Wodkowski, PawelX wrote: > > > > Though, that said, doesn't it seem to anyone else like serialization of > > > > enqueue >

[dpdk-dev] Added Spinlock to l3fwd-vf example to prevent race conditioning

2014-12-10 Thread Neil Horman
On Wed, Dec 10, 2014 at 08:18:36AM +, Wodkowski, PawelX wrote: > > Though, that said, doesn't it seem to anyone else like serialization of > > enqueue > > to a port should be the responsibility of the library, not the application? > > > > Neil > > From my knowledge it is an application resp

[dpdk-dev] Added Spinlock to l3fwd-vf example to prevent race conditioning

2014-12-10 Thread Wodkowski, PawelX
> Though, that said, doesn't it seem to anyone else like serialization of > enqueue > to a port should be the responsibility of the library, not the application? > > Neil >From my knowledge it is an application responsibility to serialize access to queue on particular port. Pawel

[dpdk-dev] Added Spinlock to l3fwd-vf example to prevent race conditioning

2014-12-10 Thread Thomas Monjalon
2014-12-08 09:45, Neil Horman: > On Tue, Jul 08, 2014 at 12:16:24PM +0100, Daniel Mrzyglod wrote: > > Signed-off-by: Daniel Mrzyglod > Acked-by: Neil Horman Someone to provide an explanation for commit log? Thanks -- Thomas

[dpdk-dev] Added Spinlock to l3fwd-vf example to prevent race conditioning

2014-12-08 Thread Neil Horman
On Tue, Jul 08, 2014 at 12:16:24PM +0100, Daniel Mrzyglod wrote: > Signed-off-by: Daniel Mrzyglod > > --- > examples/l3fwd-vf/main.c |6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/examples/l3fwd-vf/main.c b/examples/l3fwd-vf/main.c > index 2ca5c21..57852d0 10064