Re: [dpdk-dev] ABI and inline functions

2019-04-30 Thread Thomas Monjalon
24/04/2019 14:22, Ray Kinsella: > On 24/04/2019 12:08, Burakov, Anatoly wrote: > > To me, part of the problem is that DPDK is an "everything and the > > kitchen sink" kind of library where there is a bunch of drivers, a whole > > quasi-OS layer of dealing with hardware in a cross-platform manner, a

Re: [dpdk-dev] ABI and inline functions

2019-04-24 Thread Stephen Hemminger
On Wed, 24 Apr 2019 13:54:51 +0100 "Burakov, Anatoly" wrote: > On 24-Apr-19 1:22 PM, Ray Kinsella wrote: > > > > On 24/04/2019 12:08, Burakov, Anatoly wrote: > >> On 23-Apr-19 3:12 PM, Ray Kinsella wrote: > >>> > >>> > >>> On 18/04/2019 11:28, Bruce Richardson wrote: > On Thu, Apr 18,

Re: [dpdk-dev] ABI and inline functions

2019-04-24 Thread Burakov, Anatoly
On 24-Apr-19 1:22 PM, Ray Kinsella wrote: On 24/04/2019 12:08, Burakov, Anatoly wrote: On 23-Apr-19 3:12 PM, Ray Kinsella wrote: On 18/04/2019 11:28, Bruce Richardson wrote: On Thu, Apr 18, 2019 at 04:34:53AM +, Honnappa Nagarahalli wrote: On Wed, Apr 17, 2019 at 05:12:43AM +, Hon

Re: [dpdk-dev] ABI and inline functions

2019-04-24 Thread Ray Kinsella
On 24/04/2019 12:08, Burakov, Anatoly wrote: > On 23-Apr-19 3:12 PM, Ray Kinsella wrote: >> >> >> On 18/04/2019 11:28, Bruce Richardson wrote: >>> On Thu, Apr 18, 2019 at 04:34:53AM +, Honnappa Nagarahalli wrote: > > On Wed, Apr 17, 2019 at 05:12:43AM +, Honnappa Nagarahalli wrote

Re: [dpdk-dev] ABI and inline functions

2019-04-24 Thread Burakov, Anatoly
On 23-Apr-19 3:12 PM, Ray Kinsella wrote: On 18/04/2019 11:28, Bruce Richardson wrote: On Thu, Apr 18, 2019 at 04:34:53AM +, Honnappa Nagarahalli wrote: On Wed, Apr 17, 2019 at 05:12:43AM +, Honnappa Nagarahalli wrote: Hello, There was a conversation [1] in the context of RC

Re: [dpdk-dev] ABI and inline functions

2019-04-24 Thread Bruce Richardson
On Wed, Apr 24, 2019 at 05:08:46AM +, Honnappa Nagarahalli wrote: > > > > On Wed, Apr 17, 2019 at 05:12:43AM +, Honnappa Nagarahalli > > wrote: > > > > > Hello, > > > > > > > > 2. If the situation is as in #1, but the structures in question are > > > > passed to non-inline DPDK functions.

Re: [dpdk-dev] ABI and inline functions

2019-04-23 Thread Honnappa Nagarahalli
> On 18/04/2019 11:28, Bruce Richardson wrote: > > On Thu, Apr 18, 2019 at 04:34:53AM +, Honnappa Nagarahalli wrote: > >>> > >>> On Wed, Apr 17, 2019 at 05:12:43AM +, Honnappa Nagarahalli > wrote: > Hello, > There was a conversation [1] in the context of RCU library. I > tho

Re: [dpdk-dev] ABI and inline functions

2019-04-23 Thread Honnappa Nagarahalli
> > > On Wed, Apr 17, 2019 at 05:12:43AM +, Honnappa Nagarahalli > wrote: > > > > Hello, > > > > There was a conversation [1] in the context of RCU library. I > > > > thought it needs participation from broader audience. Summary for > > > > the context (please look at [1] for full detai

Re: [dpdk-dev] ABI and inline functions

2019-04-23 Thread Ray Kinsella
o: Honnappa Nagarahalli >>> Cc: dev@dpdk.org; Stephen Hemminger ; >>> Ananyev, Konstantin ; tho...@monjalon.net; >>> Ray Kinsella ; nd >>> Subject: Re: [dpdk-dev] ABI and inline functions >>> >>>> 2) Every function that is not in

Re: [dpdk-dev] ABI and inline functions

2019-04-23 Thread Ray Kinsella
On 18/04/2019 11:28, Bruce Richardson wrote: > On Thu, Apr 18, 2019 at 04:34:53AM +, Honnappa Nagarahalli wrote: >>> >>> On Wed, Apr 17, 2019 at 05:12:43AM +, Honnappa Nagarahalli wrote: Hello, There was a conversation [1] in the context of RCU library. I thought it nee

Re: [dpdk-dev] ABI and inline functions

2019-04-18 Thread Bruce Richardson
On Thu, Apr 18, 2019 at 04:34:53AM +, Honnappa Nagarahalli wrote: > > > > On Wed, Apr 17, 2019 at 05:12:43AM +, Honnappa Nagarahalli wrote: > > > Hello, > > > There was a conversation [1] in the context of RCU library. I thought > > > it needs participation from broader audience. Summary

Re: [dpdk-dev] ABI and inline functions

2019-04-17 Thread Honnappa Nagarahalli
> > On Wed, Apr 17, 2019 at 05:12:43AM +, Honnappa Nagarahalli wrote: > > Hello, > > There was a conversation [1] in the context of RCU library. I thought > > it needs participation from broader audience. Summary for the context > > (please look at [1] for full details) > > > > Thanks for

Re: [dpdk-dev] ABI and inline functions

2019-04-17 Thread Stephen Hemminger
> > Ananyev, Konstantin ; tho...@monjalon.net; > > Ray Kinsella ; nd > > Subject: Re: [dpdk-dev] ABI and inline functions > > > > > 2) Every function that is not in the direct datapath (fastpath?) > > > should not be inline. Exceptions or things like

Re: [dpdk-dev] ABI and inline functions

2019-04-17 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: dev On Behalf Of Bruce Richardson > Sent: Wednesday, April 17, 2019 2:07 PM > To: Honnappa Nagarahalli > Cc: dev@dpdk.org; Stephen Hemminger ; > Ananyev, Konstantin ; tho...@monjalon.net; > Ray Kinsella ; nd > Subject: Re: [dpdk-dev]

Re: [dpdk-dev] ABI and inline functions

2019-04-17 Thread Stephen Hemminger
On Wed, 17 Apr 2019 09:36:38 +0100 Bruce Richardson wrote: > > > > Coming to 1), I think DPDK cannot provide ABI compatibility unless all the > > inline functions are converted to normal functions and symbol versioning is > > done for those (not bothering about performance). > > > I disagre

Re: [dpdk-dev] ABI and inline functions

2019-04-17 Thread Bruce Richardson
On Wed, Apr 17, 2019 at 05:12:43AM +, Honnappa Nagarahalli wrote: > Hello, > There was a conversation [1] in the context of RCU library. I thought > it needs participation from broader audience. Summary for the context (please > look at [1] for full details) > Thanks for kicking off th

[dpdk-dev] ABI and inline functions

2019-04-16 Thread Honnappa Nagarahalli
Hello, There was a conversation [1] in the context of RCU library. I thought it needs participation from broader audience. Summary for the context (please look at [1] for full details) 1) How do we provide ABI compatibility when the code base contains inline functions? Unless we freeze