Re: [dpdk-dev] [PATCH v6 33/33] doc: add trace library guide

2020-04-21 Thread Jerin Jacob
On Tue, Apr 21, 2020 at 2:41 PM Thomas Monjalon wrote: > > 21/04/2020 07:47, Jerin Jacob: > > On Tue, Apr 21, 2020 at 5:49 AM Thomas Monjalon wrote: > > > > > > Hi, > > > > > > Below is a doc review. > > > General comment: it is better to split lines after punctuation signs > > > in order to make

Re: [dpdk-dev] [PATCH v6 33/33] doc: add trace library guide

2020-04-21 Thread Thomas Monjalon
21/04/2020 07:47, Jerin Jacob: > On Tue, Apr 21, 2020 at 5:49 AM Thomas Monjalon wrote: > > > > Hi, > > > > Below is a doc review. > > General comment: it is better to split lines after punctuation signs > > in order to make future patches easier to read. > > Thanks for the review. > Except below

Re: [dpdk-dev] [PATCH v6 33/33] doc: add trace library guide

2020-04-20 Thread Jerin Jacob
On Tue, Apr 21, 2020 at 5:49 AM Thomas Monjalon wrote: > > Hi, > > Below is a doc review. > General comment: it is better to split lines after punctuation signs > in order to make future patches easier to read. Thanks for the review. Except below two comments, Everything else accepted and fixed i

Re: [dpdk-dev] [PATCH v6 33/33] doc: add trace library guide

2020-04-20 Thread Thomas Monjalon
Hi, Below is a doc review. General comment: it is better to split lines after punctuation signs in order to make future patches easier to read. 19/04/2020 12:01, jer...@marvell.com: > +DPDK tracing library features > +- > + > +- A framework to add tracepoints in contro

[dpdk-dev] [PATCH v6 33/33] doc: add trace library guide

2020-04-19 Thread jerinj
From: Jerin Jacob Add programmar's guide for trace library support. Signed-off-by: Jerin Jacob Signed-off-by: Sunil Kumar Kori --- MAINTAINERS| 1 + doc/guides/prog_guide/index.rst| 1 + doc/guides/prog_guide/trace_lib.rst| 346 +