Re: [dpdk-dev] [PATCH v4 00/33] DPDK Trace support

2020-04-10 Thread Jerin Jacob
On Fri, Apr 10, 2020 at 8:42 PM Thomas Monjalon wrote: > > 10/04/2020 15:29, Jerin Jacob: > > On Fri, Apr 10, 2020 at 6:45 PM David Marchand > > wrote: > > > On Thu, Apr 9, 2020 at 8:27 PM Jerin Jacob wrote: > > > > # In summary: > > > > ~ > > > > # In the existing code: > > > > The

Re: [dpdk-dev] [PATCH v4 00/33] DPDK Trace support

2020-04-10 Thread Thomas Monjalon
10/04/2020 15:29, Jerin Jacob: > On Fri, Apr 10, 2020 at 6:45 PM David Marchand > wrote: > > On Thu, Apr 9, 2020 at 8:27 PM Jerin Jacob wrote: > > > # In summary: > > > ~ > > > # In the existing code: > > > The trace will be emitted when > > > a) When the trace is enabled > > > AND

Re: [dpdk-dev] [PATCH v4 00/33] DPDK Trace support

2020-04-10 Thread Thomas Monjalon
10/04/2020 17:00, David Marchand: > On Fri, Apr 10, 2020 at 4:38 PM Jerin Jacob wrote: > > > - Another comment, on the form, I can see that we talk about dataplane > > > tracepoints and fastpath API. > > > Is there a difference? or could everything be named in a consistent > > > > No. Both are the

Re: [dpdk-dev] [PATCH v4 00/33] DPDK Trace support

2020-04-10 Thread David Marchand
On Fri, Apr 10, 2020 at 4:38 PM Jerin Jacob wrote: > > - I am still looking at the event record mode. > > I just wonder why we have this notion per tracepoint. > > The documentation talks about it being an attribute of the trace > > buffers, and the described behavior looks fine. > > But if we can

Re: [dpdk-dev] [PATCH v4 00/33] DPDK Trace support

2020-04-10 Thread Jerin Jacob
On Fri, Apr 10, 2020 at 7:15 PM David Marchand wrote: > > On Fri, Apr 10, 2020 at 3:30 PM Jerin Jacob wrote: > > > > On Fri, Apr 10, 2020 at 6:45 PM David Marchand > > wrote: > > > > > > On Thu, Apr 9, 2020 at 8:27 PM Jerin Jacob wrote: > > > > > The global level is just disabling some logs eve

Re: [dpdk-dev] [PATCH v4 00/33] DPDK Trace support

2020-04-10 Thread David Marchand
On Fri, Apr 10, 2020 at 3:30 PM Jerin Jacob wrote: > > On Fri, Apr 10, 2020 at 6:45 PM David Marchand > wrote: > > > > On Thu, Apr 9, 2020 at 8:27 PM Jerin Jacob wrote: > > > > The global level is just disabling some logs even if it is enabled > > > > in the logtype level. > > > > It only makes

Re: [dpdk-dev] [PATCH v4 00/33] DPDK Trace support

2020-04-10 Thread Jerin Jacob
On Fri, Apr 10, 2020 at 6:45 PM David Marchand wrote: > > On Thu, Apr 9, 2020 at 8:27 PM Jerin Jacob wrote: > > > The global level is just disabling some logs even if it is enabled > > > in the logtype level. > > > It only makes usage complicate. > > > We should consider only logtype levels. > >

Re: [dpdk-dev] [PATCH v4 00/33] DPDK Trace support

2020-04-10 Thread David Marchand
On Thu, Apr 9, 2020 at 8:27 PM Jerin Jacob wrote: > > The global level is just disabling some logs even if it is enabled > > in the logtype level. > > It only makes usage complicate. > > We should consider only logtype levels. > > OK. Do we care about the following use case? > # Trace only specif

Re: [dpdk-dev] [PATCH v4 00/33] DPDK Trace support

2020-04-09 Thread Jerin Jacob
On Thu, Apr 9, 2020 at 11:57 PM Jerin Jacob wrote: > > > > > > > > > They are setting levels with regex or globbing. > > > > --log-level supports 3 syntaxes today: > > > > - int (global level) > > > > - globbing:int > > > > - regex,int > > > > > > Here is my understanding.

Re: [dpdk-dev] [PATCH v4 00/33] DPDK Trace support

2020-04-09 Thread Jerin Jacob
> > > > > > They are setting levels with regex or globbing. > > > --log-level supports 3 syntaxes today: > > > - int (global level) > > > - globbing:int > > > - regex,int > > > > Here is my understanding. > > > > IMO, Actual Syntax is > > - int (global level) > >

Re: [dpdk-dev] [PATCH v4 00/33] DPDK Trace support

2020-04-09 Thread Thomas Monjalon
09/04/2020 18:34, Jerin Jacob: > On Thu, Apr 9, 2020 at 9:30 PM Thomas Monjalon wrote: > > 09/04/2020 17:36, Jerin Jacob: > > > On Thu, Apr 9, 2020 at 7:30 PM Thomas Monjalon > > > wrote: > > > > As discussed somewhere else, please do not introduce global level > > > > in rte_trace. I think it i

Re: [dpdk-dev] [PATCH v4 00/33] DPDK Trace support

2020-04-09 Thread Jerin Jacob
On Thu, Apr 9, 2020 at 9:30 PM Thomas Monjalon wrote: > > 09/04/2020 17:36, Jerin Jacob: > > On Thu, Apr 9, 2020 at 7:30 PM Thomas Monjalon wrote: > > > 03/04/2020 17:36, jer...@marvell.com: > > > > Features: > > > > ~ > > > > - APIs and Features are similar to rte_log dynamic framework >

Re: [dpdk-dev] [PATCH v4 00/33] DPDK Trace support

2020-04-09 Thread Thomas Monjalon
09/04/2020 17:36, Jerin Jacob: > On Thu, Apr 9, 2020 at 7:30 PM Thomas Monjalon wrote: > > 03/04/2020 17:36, jer...@marvell.com: > > > Features: > > > ~ > > > - APIs and Features are similar to rte_log dynamic framework > > > API(expect log prints on stdout vs it dumps on trace file) > > >

Re: [dpdk-dev] [PATCH v4 00/33] DPDK Trace support

2020-04-09 Thread Jerin Jacob
On Thu, Apr 9, 2020 at 7:30 PM Thomas Monjalon wrote: > > Hi, > > 03/04/2020 17:36, jer...@marvell.com: > > Features: > > ~ > > - APIs and Features are similar to rte_log dynamic framework > > API(expect log prints on stdout vs it dumps on trace file) > > A log can print to syslog as well.

Re: [dpdk-dev] [PATCH v4 00/33] DPDK Trace support

2020-04-09 Thread Thomas Monjalon
Hi, 03/04/2020 17:36, jer...@marvell.com: > Features: > ~ > - APIs and Features are similar to rte_log dynamic framework > API(expect log prints on stdout vs it dumps on trace file) A log can print to syslog as well. As discussed somewhere else, please do not introduce global level in rt

[dpdk-dev] [PATCH v4 00/33] DPDK Trace support

2020-04-03 Thread jerinj
From: Jerin Jacob v4: ~~ This patch depends on http://patches.dpdk.org/patch/67758/ Depends-on:series-9191 1) Rebased to master. 2) Adapted to latest EAL directory structure change. 3) Fix possible build issue with out of tree application wherein it does not define -DALLOW_EXPERIMENTAL_API.