Re: [dpdk-dev] [PATCH v3 4/5] net/tap: fix close a valid fd

2020-04-07 Thread wangyunjian
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Tuesday, April 7, 2020 10:56 PM > To: wangyunjian > Cc: dev@dpdk.org; keith.wi...@intel.com; Lilijun (Jerry) > ; xudingke ; > sta...@dpdk.org > Subject: Re: [dpdk-dev] [PA

Re: [dpdk-dev] [PATCH v3 4/5] net/tap: fix close a valid fd

2020-04-07 Thread Stephen Hemminger
On Tue, 7 Apr 2020 12:23:26 +0800 wangyunjian wrote: > The internals is freed and setted NULL in the rte_eth_dev_release_port() The word "setted" is awkward in this phrase. Better wording would be: The internal structure is freed and set to NULL in rte_eth_dev_release_port()

[dpdk-dev] [PATCH v3 4/5] net/tap: fix close a valid fd

2020-04-06 Thread wangyunjian
From: Yunjian Wang The internals is freed and setted NULL in the rte_eth_dev_release_port() and zero is a valid fd. As a result, a valid fd is incorrectly closed. Fixes: 3101191c63ab ("net/tap: fix device removal when no queue exist") CC: sta...@dpdk.org Signed-off-by: Yunjian Wang --- driver