Re: [dpdk-dev] [PATCH v2 2/2] octeontx: move mbox to common folder

2018-03-20 Thread Pavan Nikhilesh
Hi Hemant, On Tue, Mar 20, 2018 at 08:31:42PM +0530, Hemant Agrawal wrote: > > HI Pavan, >     One quick comment > > On 3/20/2018 8:10 PM, Pavan Nikhilesh wrote: > > -LDLIBS += -lrte_eal -lrte_eventdev -lrte_mempool_octeontx > > -lrte_pmd_octeontx > > +LDLIBS += -lrte_eal -lrte_eventdev -lrte_oct

Re: [dpdk-dev] [PATCH v2 2/2] octeontx: move mbox to common folder

2018-03-20 Thread Hemant Agrawal
HI Pavan,     One quick comment On 3/20/2018 8:10 PM, Pavan Nikhilesh wrote: -LDLIBS += -lrte_eal -lrte_eventdev -lrte_mempool_octeontx -lrte_pmd_octeontx +LDLIBS += -lrte_eal -lrte_eventdev -lrte_octeontx_common -lrte_pmd_octeontx Typically the naming convention for driver based libraries is

[dpdk-dev] [PATCH v2 2/2] octeontx: move mbox to common folder

2018-03-20 Thread Pavan Nikhilesh
Move commonly used functions across mempool, event and net devices to a common folder in drivers. Signed-off-by: Pavan Nikhilesh --- drivers/common/Makefile| 4 ++ drivers/common/meson.build | 1 + drivers/common/octeontx/Makefile