Re: [dpdk-dev] [PATCH v2 1/2] drivers: add common folder

2018-03-20 Thread Trahe, Fiona
; lir...@marvell.com; Trahe, Fiona ; > shreyansh.j...@nxp.com; > hemant.agra...@nxp.com; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 1/2] drivers: add common folder > > 20/03/2018 18:01, Bruce Richardson: > > On Tue, Mar 20, 2018 at 09:36:25PM +0530, Pavan Nikhilesh wrote: &

Re: [dpdk-dev] [PATCH v2 1/2] drivers: add common folder

2018-03-20 Thread Thomas Monjalon
20/03/2018 18:01, Bruce Richardson: > On Tue, Mar 20, 2018 at 09:36:25PM +0530, Pavan Nikhilesh wrote: > > Hi Thomas, > > > > On Tue, Mar 20, 2018 at 04:45:47PM +0100, Thomas Monjalon wrote: > > > 20/03/2018 15:40, Pavan Nikhilesh: > > > > Add driver/common folder and skeleton makefile for adding

Re: [dpdk-dev] [PATCH v2 1/2] drivers: add common folder

2018-03-20 Thread Bruce Richardson
On Tue, Mar 20, 2018 at 09:36:25PM +0530, Pavan Nikhilesh wrote: > Hi Thomas, > > On Tue, Mar 20, 2018 at 04:45:47PM +0100, Thomas Monjalon wrote: > > 20/03/2018 15:40, Pavan Nikhilesh: > > > Add driver/common folder and skeleton makefile for adding commonly > > > used functions across mempool, ev

Re: [dpdk-dev] [PATCH v2 1/2] drivers: add common folder

2018-03-20 Thread Pavan Nikhilesh
Hi Thomas, On Tue, Mar 20, 2018 at 04:45:47PM +0100, Thomas Monjalon wrote: > 20/03/2018 15:40, Pavan Nikhilesh: > > Add driver/common folder and skeleton makefile for adding commonly used > > functions across mempool, event and net devices. > > I am not sure there is a real benefit of introducing

Re: [dpdk-dev] [PATCH v2 1/2] drivers: add common folder

2018-03-20 Thread Thomas Monjalon
20/03/2018 15:40, Pavan Nikhilesh: > Add driver/common folder and skeleton makefile for adding commonly used > functions across mempool, event and net devices. I am not sure there is a real benefit of introducing such new directory. Is it only solving the choice of where you add files used by seve

[dpdk-dev] [PATCH v2 1/2] drivers: add common folder

2018-03-20 Thread Pavan Nikhilesh
Add driver/common folder and skeleton makefile for adding commonly used functions across mempool, event and net devices. Signed-off-by: Pavan Nikhilesh --- v2 Changes: - Removed dependency on bus. drivers/Makefile | 13 +++-- drivers/common/Makefile| 7 +++ drivers