Re: [dpdk-dev] [PATCH v2] service: fix service lcore stop function

2017-09-15 Thread Thomas Monjalon
> > lcore_states store the state of the lcore. Fixing the invalid > > dereference of lcore_states with service number > > > > Unit test case service_lcore_start_stop fails with the above fix. > > Service core was stopped without stopping the service. > > > > This commit fixes the test by adding n

Re: [dpdk-dev] [PATCH v2] service: fix service lcore stop function

2017-09-06 Thread Guduri Prathyusha
On Wed, Sep 06, 2017 at 08:53:30AM +, Van Haaren, Harry wrote: > > From: Guduri Prathyusha [mailto:gprathyu...@caviumnetworks.com] > > Sent: Wednesday, September 6, 2017 8:16 AM > > To: Van Haaren, Harry > > Cc: dev@dpdk.org; Guduri Prathyusha > > Subject: [dpd

Re: [dpdk-dev] [PATCH v2] service: fix service lcore stop function

2017-09-06 Thread Van Haaren, Harry
> From: Guduri Prathyusha [mailto:gprathyu...@caviumnetworks.com] > Sent: Wednesday, September 6, 2017 8:16 AM > To: Van Haaren, Harry > Cc: dev@dpdk.org; Guduri Prathyusha > Subject: [dpdk-dev] [PATCH v2] service: fix service lcore stop function > > lcore_states store t

[dpdk-dev] [PATCH v2] service: fix service lcore stop function

2017-09-06 Thread Guduri Prathyusha
lcore_states store the state of the lcore. Fixing the invalid dereference of lcore_states with service number Unit test case service_lcore_start_stop fails with the above fix. Service core was stopped without stopping the service. This commit fixes the test by adding negative and positive cases o