Re: [dpdk-dev] [PATCH] eal: fix clang compilation error on ARM64

2018-04-11 Thread Pavan Nikhilesh
On Wed, Apr 11, 2018 at 10:46:47AM +0200, Thomas Monjalon wrote: > 11/04/2018 10:38, Pavan Nikhilesh: > > On Tue, Apr 10, 2018 at 11:35:15PM +0200, Thomas Monjalon wrote: > > > Hi, big issue here. > > > This patch does not compile on Linux with ICC or GCC < 4.9 > > > because of a missing C11 header

Re: [dpdk-dev] [PATCH] eal: fix clang compilation error on ARM64

2018-04-11 Thread Thomas Monjalon
11/04/2018 10:38, Pavan Nikhilesh: > On Tue, Apr 10, 2018 at 11:35:15PM +0200, Thomas Monjalon wrote: > > Hi, big issue here. > > This patch does not compile on Linux with ICC or GCC < 4.9 > > because of a missing C11 header: > > #include > > > > GCC 4.9 is recommended in doc/guides/linux_gsg/

Re: [dpdk-dev] [PATCH] eal: fix clang compilation error on ARM64

2018-04-11 Thread Pavan Nikhilesh
On Tue, Apr 10, 2018 at 11:35:15PM +0200, Thomas Monjalon wrote: > Hi, big issue here. > This patch does not compile on Linux with ICC or GCC < 4.9 > because of a missing C11 header: > #include > > GCC 4.9 is recommended in doc/guides/linux_gsg/sys_reqs.rst. > But GCC 4.8 is used by SLES 12,

Re: [dpdk-dev] [PATCH] eal: fix clang compilation error on ARM64

2018-04-10 Thread Thomas Monjalon
Hi, big issue here. This patch does not compile on Linux with ICC or GCC < 4.9 because of a missing C11 header: #include GCC 4.9 is recommended in doc/guides/linux_gsg/sys_reqs.rst. But GCC 4.8 is used by SLES 12, RHEL 7, etc... Note: Intel compilation tests are running with a backlog of

Re: [dpdk-dev] [PATCH] eal: fix clang compilation error on ARM64

2018-04-10 Thread Thomas Monjalon
06/04/2018 20:25, Pavan Nikhilesh: > On Fri, Apr 06, 2018 at 06:24:34PM +0200, Thomas Monjalon wrote: > > 06/04/2018 13:01, Pavan Nikhilesh: > > > Use __atomic_exchange_n instead of __atomic_exchange_(2/4/8). > > > > > > Fixes: ff2863570fcc ("eal: introduce atomic exchange operation") > > > > Pleas

Re: [dpdk-dev] [PATCH] eal: fix clang compilation error on ARM64

2018-04-06 Thread Pavan Nikhilesh
On Fri, Apr 06, 2018 at 06:24:34PM +0200, Thomas Monjalon wrote: > 06/04/2018 13:01, Pavan Nikhilesh: > > Use __atomic_exchange_n instead of __atomic_exchange_(2/4/8). > > > > Fixes: ff2863570fcc ("eal: introduce atomic exchange operation") > > Please, could you provide a log of the error? CC ea

Re: [dpdk-dev] [PATCH] eal: fix clang compilation error on ARM64

2018-04-06 Thread Thomas Monjalon
06/04/2018 13:01, Pavan Nikhilesh: > Use __atomic_exchange_n instead of __atomic_exchange_(2/4/8). > > Fixes: ff2863570fcc ("eal: introduce atomic exchange operation") Please, could you provide a log of the error? Why __atomic_exchange_n is fixing the compilation?

[dpdk-dev] [PATCH] eal: fix clang compilation error on ARM64

2018-04-06 Thread Pavan Nikhilesh
Use __atomic_exchange_n instead of __atomic_exchange_(2/4/8). Fixes: ff2863570fcc ("eal: introduce atomic exchange operation") Signed-off-by: Pavan Nikhilesh --- lib/librte_eal/common/include/generic/rte_atomic.h | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/lib/li