Re: [dpdk-dev] [v4] net/virtio: set offload flag for jumbo frames

2019-02-01 Thread Ilya Maximets
On 01.02.2019 18:13, Jens Freimann wrote: > On Fri, Feb 01, 2019 at 05:27:37PM +0300, Ilya Maximets wrote: >> On 01.02.2019 13:03, Jens Freimann wrote: >>> +    if (host_features & (1ULL << VIRTIO_NET_F_MTU)) { >>> +    uint32_t ether_hdr_len = ETHER_HDR_LEN + VLAN_TAG_LEN + >>> +    hw

Re: [dpdk-dev] [v4] net/virtio: set offload flag for jumbo frames

2019-02-01 Thread Jens Freimann
On Fri, Feb 01, 2019 at 05:27:37PM +0300, Ilya Maximets wrote: On 01.02.2019 13:03, Jens Freimann wrote: + if (host_features & (1ULL << VIRTIO_NET_F_MTU)) { + uint32_t ether_hdr_len = ETHER_HDR_LEN + VLAN_TAG_LEN + + hw->vtnet_hdr_size; + i

Re: [dpdk-dev] [v4] net/virtio: set offload flag for jumbo frames

2019-02-01 Thread Ilya Maximets
On 01.02.2019 13:03, Jens Freimann wrote: > Port configuration fails because offload flags don't match the expected > value when max-pkt-len is set to a value that should enable receive port > offloading but doesn't. > > There are two cases to consider: > > 1. VIRTIO_NET_F_MTU is set. Then we nee