Re: [dpdk-dev] [v2] telemetry: fix json output buffer size

2021-10-07 Thread Power, Ciara
Hi Gowrishankar, >-Original Message- >From: Gowrishankar Muthukrishnan >Sent: Thursday 30 September 2021 10:01 >To: Power, Ciara ; dev@dpdk.org >Cc: Richardson, Bruce >Subject: RE: [v2] telemetry: fix json output buffer size > >> >Also, I propose if we can have platform defined upper lim

Re: [dpdk-dev] [v2] telemetry: fix json output buffer size

2021-09-30 Thread Gowrishankar Muthukrishnan
> >Also, I propose if we can have platform defined upper limits (esp > >MAX_CMD_LEN, MAX_SINGLE_STRING_LEN etc) so that, we need not revisit > >lib/telemetry for platform needs (and I don't think one size fits all > >platform, may be excess too). > >Thoughts ? > > I am not sure why it is needed to

Re: [dpdk-dev] [v2] telemetry: fix json output buffer size

2021-09-30 Thread Power, Ciara
Hi Gowrishankar, >-Original Message- >From: Gowrishankar Muthukrishnan >Sent: Thursday 23 September 2021 06:53 >To: Power, Ciara ; dev@dpdk.org >Cc: Richardson, Bruce >Subject: RE: [v2] telemetry: fix json output buffer size > >Hi Ciara, >> I am not sure about why we would want this to a

Re: [dpdk-dev] [v2] telemetry: fix json output buffer size

2021-09-22 Thread Gowrishankar Muthukrishnan
Hi Ciara, > I am not sure about why we would want this to allow for > "RTE_TEL_MAX_SINGLE_STRING_LEN - 6". > The RTE_TEL_MAX_SINGLE_STRING_LEN is used to represent the max size of a > singular string value e.g. the response to client being {"" : " value > here up to max size in length>" } > > I

Re: [dpdk-dev] [v2] telemetry: fix json output buffer size

2021-09-22 Thread Power, Ciara
Hi Gowrishankar, >-Original Message- >From: Gowrishankar Muthukrishnan >Sent: Tuesday 21 September 2021 12:03 >To: dev@dpdk.org >Cc: Power, Ciara ; Gowrishankar Muthukrishnan > >Subject: [v2] telemetry: fix json output buffer size > >Fix json output buffer size for a single largest value

[dpdk-dev] [v2] telemetry: fix json output buffer size

2021-09-21 Thread Gowrishankar Muthukrishnan
Fix json output buffer size for a single largest value. Fixes: 52af6ccb2b39 ("telemetry: add utility functions for creating JSON") v2: - split from series 18768 ("cnxk: enable telemetry endpoints"). Signed-off-by: Gowrishankar Muthukrishnan --- lib/telemetry/telemetry_json.h | 7 +-- 1 fi