Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/7] ethdev: fix port data reset timing

2018-04-25 Thread Matan Azrad
Hi Ferruh From: Ferruh Yigit, Wednesday, April 25, 2018 3:54 PM > On 4/25/2018 1:16 PM, Matan Azrad wrote: > > Hi all > > > > From: Ferruh Yigit, Thursday, April 19, 2018 2:08 PM > >>> But rte_eth_dev_release_port() is still broken because of this > >>> change, please check _rte_eth_dev_callback

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/7] ethdev: fix port data reset timing

2018-04-25 Thread Ferruh Yigit
On 4/25/2018 1:16 PM, Matan Azrad wrote: > Hi all > > From: Ferruh Yigit, Thursday, April 19, 2018 2:08 PM >>> But rte_eth_dev_release_port() is still broken because of this change, >>> please check _rte_eth_dev_callback_process() which uses dev->data- >>> port_id. > > The issue is that a DESTROY

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/7] ethdev: fix port data reset timing

2018-04-25 Thread Ori Kam
; Bruce > Richardson ; Konstantin Ananyev > ; sta...@dpdk.org; Olga Shern > > Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/7] ethdev: fix port data > reset timing > > Hi all > > From: Ferruh Yigit, Thursday, April 19, 2018 2:08 PM > > > But rte_eth_dev_release_po

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/7] ethdev: fix port data reset timing

2018-04-25 Thread Matan Azrad
Hi all From: Ferruh Yigit, Thursday, April 19, 2018 2:08 PM > > But rte_eth_dev_release_port() is still broken because of this change, > > please check _rte_eth_dev_callback_process() which uses dev->data- > >port_id. The issue is that a DESTROY callback gets port_id=0 all the time, regardless t

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/7] ethdev: fix port data reset timing

2018-04-19 Thread Ferruh Yigit
On 3/30/2018 11:39 AM, Ferruh Yigit wrote: > On 3/28/2018 1:07 PM, Matan Azrad wrote: >> Hi Ferruh >> >>> From: Ferruh Yigit, Wednesday, March 28, 2018 1:38 AM >>> On 3/5/2018 3:12 PM, Matan Azrad wrote: Hi Ferruh From: Ferruh Yigit, Sent: Monday, March 5, 2018 5:07 PM > On 3/5/2

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/7] ethdev: fix port data reset timing

2018-03-30 Thread Ferruh Yigit
On 3/28/2018 1:07 PM, Matan Azrad wrote: > Hi Ferruh > >> From: Ferruh Yigit, Wednesday, March 28, 2018 1:38 AM >> On 3/5/2018 3:12 PM, Matan Azrad wrote: >>> Hi Ferruh >>> >>> From: Ferruh Yigit, Sent: Monday, March 5, 2018 5:07 PM On 3/5/2018 2:52 PM, Matan Azrad wrote: > HI > >

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/7] ethdev: fix port data reset timing

2018-03-28 Thread Matan Azrad
Hi Ferruh > From: Ferruh Yigit, Wednesday, March 28, 2018 1:38 AM > On 3/5/2018 3:12 PM, Matan Azrad wrote: > > Hi Ferruh > > > > From: Ferruh Yigit, Sent: Monday, March 5, 2018 5:07 PM > >> On 3/5/2018 2:52 PM, Matan Azrad wrote: > >>> HI > >>> > >>> From: Ferruh Yigit, Sent: Monday, March 5, 201

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/7] ethdev: fix port data reset timing

2018-03-27 Thread Ferruh Yigit
On 3/5/2018 3:12 PM, Matan Azrad wrote: > Hi Ferruh > > From: Ferruh Yigit, Sent: Monday, March 5, 2018 5:07 PM >> On 3/5/2018 2:52 PM, Matan Azrad wrote: >>> HI >>> >>> From: Ferruh Yigit, Sent: Monday, March 5, 2018 1:24 PM On 1/18/2018 4:35 PM, Matan Azrad wrote: > rte_eth_dev_data str

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/7] ethdev: fix port data reset timing

2018-03-05 Thread Matan Azrad
Hi Ferruh From: Ferruh Yigit, Sent: Monday, March 5, 2018 5:07 PM > On 3/5/2018 2:52 PM, Matan Azrad wrote: > > HI > > > > From: Ferruh Yigit, Sent: Monday, March 5, 2018 1:24 PM > >> On 1/18/2018 4:35 PM, Matan Azrad wrote: > >>> rte_eth_dev_data structure is allocated per ethdev port and can be

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/7] ethdev: fix port data reset timing

2018-03-05 Thread Ferruh Yigit
On 3/5/2018 2:52 PM, Matan Azrad wrote: > HI > > From: Ferruh Yigit, Sent: Monday, March 5, 2018 1:24 PM >> On 1/18/2018 4:35 PM, Matan Azrad wrote: >>> rte_eth_dev_data structure is allocated per ethdev port and can be >>> used to get a data of the port internally. >>> >>> rte_eth_dev_attach_seco

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/7] ethdev: fix port data reset timing

2018-03-05 Thread Matan Azrad
HI From: Ferruh Yigit, Sent: Monday, March 5, 2018 1:24 PM > On 1/18/2018 4:35 PM, Matan Azrad wrote: > > rte_eth_dev_data structure is allocated per ethdev port and can be > > used to get a data of the port internally. > > > > rte_eth_dev_attach_secondary tries to find the port identifier using >

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/7] ethdev: fix port data reset timing

2018-03-05 Thread Ferruh Yigit
On 1/18/2018 4:35 PM, Matan Azrad wrote: > rte_eth_dev_data structure is allocated per ethdev port and can be > used to get a data of the port internally. > > rte_eth_dev_attach_secondary tries to find the port identifier using > rte_eth_dev_data name field comparison and may get an identifier of