Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/i40e: fix incorrect byte counters

2020-09-20 Thread Jiang, JunyuX
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Friday, September 18, 2020 9:42 PM > To: Igor Ryzhov ; Jiang, JunyuX > > Cc: dev@dpdk.org; Guo, Jia ; Xing, Beilei > ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/i40e: fix i

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/i40e: fix incorrect byte counters

2020-09-18 Thread Ferruh Yigit
On 9/18/2020 10:23 AM, Igor Ryzhov wrote: Hi, Your code will work only if stats are updated at least once between two overflows. > In this case it will have problems in 'i40e_stat_update_48()' too. It seems there is no way to detect if the increase in stats is N or MAX_48+N by the software.

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/i40e: fix incorrect byte counters

2020-09-18 Thread Ferruh Yigit
On 9/18/2020 4:44 AM, Jiang, JunyuX wrote: Hi Ferruh, -Original Message- From: Ferruh Yigit Sent: Wednesday, September 16, 2020 8:31 PM To: Jiang, JunyuX ; dev@dpdk.org Cc: Guo, Jia ; Xing, Beilei ; sta...@dpdk.org Subject: Re: [dpdk-stable] [PATCH v2] net/i40e: fix incorrect byte coun

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/i40e: fix incorrect byte counters

2020-09-18 Thread Igor Ryzhov
Hi, Your code will work only if stats are updated at least once between two overflows. So it's still up to the application to handle this properly. I think it should be mentioned in the docs. Igor On Fri, Sep 18, 2020 at 6:45 AM Jiang, JunyuX wrote: > Hi Ferruh, > > > -Original Message

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/i40e: fix incorrect byte counters

2020-09-17 Thread Jiang, JunyuX
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Wednesday, September 16, 2020 8:31 PM > To: Jiang, JunyuX ; dev@dpdk.org > Cc: Guo, Jia ; Xing, Beilei ; > sta...@dpdk.org > Subject: Re: [dpdk-stable] [PATCH v2] net/i40e: fix incorrect byte counters > > On 9/16/2020 2:51 AM,

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/i40e: fix incorrect byte counters

2020-09-16 Thread Ferruh Yigit
On 9/16/2020 2:51 AM, Junyu Jiang wrote: This patch fixed the issue that rx/tx bytes overflowed "Rx/Tx statistics counters overflowed"? on 48 bit limitation by enlarging the limitation. Fixes: 4861cde46116 ("i40e: new poll mode driver") Cc: sta...@dpdk.org Signed-off-by: Junyu Jiang ---

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/i40e: fix incorrect byte counters

2020-09-15 Thread Han, YingyaX
Tested-by: Yingya Han -Original Message- From: stable On Behalf Of Junyu Jiang Sent: Wednesday, September 16, 2020 9:51 AM To: dev@dpdk.org Cc: Guo, Jia ; Xing, Beilei ; Jiang, JunyuX ; sta...@dpdk.org Subject: [dpdk-stable] [PATCH v2] net/i40e: fix incorrect byte counters This patch f