Re: [dpdk-dev] [dpdk-stable] [PATCH] vdpa/mlx5: fix configuration mutex cleanup

2021-01-26 Thread Matan Azrad
From: Maxime Coquelin > On 1/26/21 11:45 AM, Matan Azrad wrote: > > > > > > From: Maxime Coquelin > >>> From: Maxime Coquelin > On 1/14/21 4:23 PM, Matan Azrad wrote: > > > > > > From: Maxime Coquelin > >> On 1/14/21 2:09 PM, Matan Azrad wrote: > >>> > >>> > >>> F

Re: [dpdk-dev] [dpdk-stable] [PATCH] vdpa/mlx5: fix configuration mutex cleanup

2021-01-26 Thread Maxime Coquelin
On 1/26/21 11:45 AM, Matan Azrad wrote: > > > From: Maxime Coquelin >>> From: Maxime Coquelin On 1/14/21 4:23 PM, Matan Azrad wrote: > > > From: Maxime Coquelin >> On 1/14/21 2:09 PM, Matan Azrad wrote: >>> >>> >>> From: Maxime Coquelin Hi Matan, >

Re: [dpdk-dev] [dpdk-stable] [PATCH] vdpa/mlx5: fix configuration mutex cleanup

2021-01-26 Thread Matan Azrad
From: Maxime Coquelin > > From: Maxime Coquelin > >> On 1/14/21 4:23 PM, Matan Azrad wrote: > >>> > >>> > >>> From: Maxime Coquelin > On 1/14/21 2:09 PM, Matan Azrad wrote: > > > > > > From: Maxime Coquelin > >> Hi Matan, > >> > >> On 1/14/21 12:49 PM, Matan Azrad wro

Re: [dpdk-dev] [dpdk-stable] [PATCH] vdpa/mlx5: fix configuration mutex cleanup

2021-01-26 Thread Maxime Coquelin
On 1/21/21 9:13 PM, Matan Azrad wrote: > > > From: Maxime Coquelin >> On 1/14/21 4:23 PM, Matan Azrad wrote: >>> >>> >>> From: Maxime Coquelin On 1/14/21 2:09 PM, Matan Azrad wrote: > > > From: Maxime Coquelin >> Hi Matan, >> >> On 1/14/21 12:49 PM, Matan Azrad wro

Re: [dpdk-dev] [dpdk-stable] [PATCH] vdpa/mlx5: fix configuration mutex cleanup

2021-01-21 Thread Matan Azrad
From: Maxime Coquelin > On 1/14/21 4:23 PM, Matan Azrad wrote: > > > > > > From: Maxime Coquelin > >> On 1/14/21 2:09 PM, Matan Azrad wrote: > >>> > >>> > >>> From: Maxime Coquelin > Hi Matan, > > On 1/14/21 12:49 PM, Matan Azrad wrote: > > Hi Maxime and David > > > > T

Re: [dpdk-dev] [dpdk-stable] [PATCH] vdpa/mlx5: fix configuration mutex cleanup

2021-01-21 Thread Maxime Coquelin
On 1/14/21 4:23 PM, Matan Azrad wrote: > > > From: Maxime Coquelin >> On 1/14/21 2:09 PM, Matan Azrad wrote: >>> >>> >>> From: Maxime Coquelin Hi Matan, On 1/14/21 12:49 PM, Matan Azrad wrote: > Hi Maxime and David > > Thank you for Review. > > From: David Ma

Re: [dpdk-dev] [dpdk-stable] [PATCH] vdpa/mlx5: fix configuration mutex cleanup

2021-01-14 Thread Matan Azrad
From: Maxime Coquelin > On 1/14/21 2:09 PM, Matan Azrad wrote: > > > > > > From: Maxime Coquelin > >> Hi Matan, > >> > >> On 1/14/21 12:49 PM, Matan Azrad wrote: > >>> Hi Maxime and David > >>> > >>> Thank you for Review. > >>> > >>> From: David Marchand > On Fri, Jan 8, 2021 at 9:48 AM Davi

Re: [dpdk-dev] [dpdk-stable] [PATCH] vdpa/mlx5: fix configuration mutex cleanup

2021-01-14 Thread Maxime Coquelin
On 1/14/21 2:09 PM, Matan Azrad wrote: > > > From: Maxime Coquelin >> Hi Matan, >> >> On 1/14/21 12:49 PM, Matan Azrad wrote: >>> Hi Maxime and David >>> >>> Thank you for Review. >>> >>> From: David Marchand On Fri, Jan 8, 2021 at 9:48 AM David Marchand wrote: >> I wonder if it

Re: [dpdk-dev] [dpdk-stable] [PATCH] vdpa/mlx5: fix configuration mutex cleanup

2021-01-14 Thread Matan Azrad
From: Maxime Coquelin > Hi Matan, > > On 1/14/21 12:49 PM, Matan Azrad wrote: > > Hi Maxime and David > > > > Thank you for Review. > > > > From: David Marchand > >> On Fri, Jan 8, 2021 at 9:48 AM David Marchand > >> wrote: > I wonder if it would be possible and cleaner to disable > c

Re: [dpdk-dev] [dpdk-stable] [PATCH] vdpa/mlx5: fix configuration mutex cleanup

2021-01-14 Thread Maxime Coquelin
Hi Matan, On 1/14/21 12:49 PM, Matan Azrad wrote: > Hi Maxime and David > > Thank you for Review. > > From: David Marchand >> On Fri, Jan 8, 2021 at 9:48 AM David Marchand >> wrote: I wonder if it would be possible and cleaner to disable cancellation on the thread while the mutex is h

Re: [dpdk-dev] [dpdk-stable] [PATCH] vdpa/mlx5: fix configuration mutex cleanup

2021-01-14 Thread Matan Azrad
Hi Maxime and David Thank you for Review. From: David Marchand > On Fri, Jan 8, 2021 at 9:48 AM David Marchand > wrote: > > > I wonder if it would be possible and cleaner to disable cancellation > > > on the thread while the mutex is held? Yes, we can cause thread to return by some global varia

Re: [dpdk-dev] [dpdk-stable] [PATCH] vdpa/mlx5: fix configuration mutex cleanup

2021-01-14 Thread David Marchand
On Fri, Jan 8, 2021 at 9:48 AM David Marchand wrote: > > I wonder if it would be possible and cleaner to disable cancellation on > > the thread while the mutex is held? > > +1 IEEE Std 1003.1-2001/Cor 2-2004, item XBD/TC2/D6/26 is applied, adding pthread_t to the list of types that are not requir

Re: [dpdk-dev] [dpdk-stable] [PATCH] vdpa/mlx5: fix configuration mutex cleanup

2021-01-08 Thread David Marchand
On Thu, Jan 7, 2021 at 7:09 PM Maxime Coquelin wrote: > On 1/6/21 7:43 AM, Matan Azrad wrote: > > When the vDPA device is closed, the driver polling thread is canceled. > > The polling thread locks the configuration mutex while it polls the CQs. > > > > When the cancellation happens, it may termin