Re: [dpdk-dev] [dpdk-stable] [PATCH] devbind: check for lspci

2018-11-13 Thread Burakov, Anatoly
On 07-Nov-18 4:01 PM, Ferruh Yigit wrote: On 11/7/2018 1:56 PM, Anatoly Burakov wrote: On some distributions (such as CentOS 7) lspci may not be installed by default, causing exceptions which are difficult to interpret. Fix devbind script to check if lspci is installed at script startup. I gu

Re: [dpdk-dev] [dpdk-stable] [PATCH] devbind: check for lspci

2018-11-12 Thread Burakov, Anatoly
On 10-Nov-18 11:03 AM, Rami Rosen wrote: HI Anatoly, Do all other distros have lspci in package called pciutils? If not, i prefer to keep it the way it is. Your original patch have: +if ret != 0: +print("'lspci' not found - please install 'lspci'") And I suggest to consi

Re: [dpdk-dev] [dpdk-stable] [PATCH] devbind: check for lspci

2018-11-10 Thread Rami Rosen
HI Anatoly, >Do all other distros have lspci in package called pciutils? If not, i >prefer to keep it the way it is. Your original patch have: +if ret != 0: +print("'lspci' not found - please install 'lspci'") And I suggest to consider changing it to: >> + if ret != 0: >>

Re: [dpdk-dev] [dpdk-stable] [PATCH] devbind: check for lspci

2018-11-09 Thread Burakov, Anatoly
On 08-Nov-18 8:38 PM, Rami Rosen wrote: Hi, Anatoly, This is really minor nitpick, but in case you decide to send V2, I believe it should say >> + if ret != 0: >> +            print("'lspci' not found - please install pciutils') as the name of the package containing lspci is pciutils in cen

Re: [dpdk-dev] [dpdk-stable] [PATCH] devbind: check for lspci

2018-11-08 Thread Rami Rosen
Hi, Anatoly, This is really minor nitpick, but in case you decide to send V2, I believe it should say >> + if ret != 0: >> +print("'lspci' not found - please install pciutils') as the name of the package containing lspci is pciutils in centos. Regards, Rami Rosen >

Re: [dpdk-dev] [dpdk-stable] [PATCH] devbind: check for lspci

2018-11-07 Thread Ferruh Yigit
On 11/7/2018 4:30 PM, Burakov, Anatoly wrote: > On 07-Nov-18 4:01 PM, Ferruh Yigit wrote: >> On 11/7/2018 1:56 PM, Anatoly Burakov wrote: >>> On some distributions (such as CentOS 7) lspci may not be installed >>> by default, causing exceptions which are difficult to interpret. >>> >>> Fix devbind

Re: [dpdk-dev] [dpdk-stable] [PATCH] devbind: check for lspci

2018-11-07 Thread Burakov, Anatoly
On 07-Nov-18 4:01 PM, Ferruh Yigit wrote: On 11/7/2018 1:56 PM, Anatoly Burakov wrote: On some distributions (such as CentOS 7) lspci may not be installed by default, causing exceptions which are difficult to interpret. Fix devbind script to check if lspci is installed at script startup. I gu

Re: [dpdk-dev] [dpdk-stable] [PATCH] devbind: check for lspci

2018-11-07 Thread Ferruh Yigit
On 11/7/2018 1:56 PM, Anatoly Burakov wrote: > On some distributions (such as CentOS 7) lspci may not be installed > by default, causing exceptions which are difficult to interpret. > > Fix devbind script to check if lspci is installed at script startup. I guess we need lspci for `--status`, bind