Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix Segment fault when start fwd

2019-09-23 Thread Wang, ShougangX
org > > Cc: Lu, Wenzhuo ; Yang, Qiming > > ; sta...@dpdk.org > > Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix Segment > > fault when start fwd > > > > On 9/17/2019 10:22 AM, Wang, ShougangX wrote: > > >> Let's assume port alread

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix Segment fault when start fwd

2019-09-23 Thread Iremonger, Bernard
pdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix Segment > fault when start fwd > > On 9/17/2019 10:22 AM, Wang, ShougangX wrote: > >> Let's assume port already stopped before calling the reset, reset > >> will cause port to be started. > > > > Indeed, automatic

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix Segment fault when start fwd

2019-09-23 Thread Ferruh Yigit
On 9/17/2019 10:22 AM, Wang, ShougangX wrote: >> Let's assume port already stopped before calling the reset, reset will cause >> port >> to be started. > > Indeed, automatically start looks strange in this case. User explicitly do > the > "port start" command should be better. > >> I am for us

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix Segment fault when start fwd

2019-09-17 Thread Wang, ShougangX
> Let's assume port already stopped before calling the reset, reset will cause > port > to be started. Indeed, automatically start looks strange in this case. User explicitly do the "port start" command should be better. > I am for user explicitly do the stop, reset and start commands, instead

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix Segment fault when start fwd

2019-09-16 Thread Ferruh Yigit
On 9/16/2019 7:37 AM, Wang, ShougangX wrote: > Hi Ferruh > > Thanks for your reply. > >> Not sure if 'reset' command should do more than it says, if there is a >> requirement that port should be stopped, why not add this condition with an >> error message so that user can stop the port in advance

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix Segment fault when start fwd

2019-09-15 Thread Wang, ShougangX
Hi Ferruh Thanks for your reply. > Not sure if 'reset' command should do more than it says, if there is a > requirement that port should be stopped, why not add this condition with an > error message so that user can stop the port in advance if she wants. Firstly, port must be stopped before res

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix Segment fault when start fwd

2019-09-13 Thread Ferruh Yigit
On 9/6/2019 2:28 AM, Wang ShougangX wrote: > This patch fixed the reset function to avoid crash when user don't > call port reset , port stop and port start functions as sequence. > > Fixes: 97f1e19679 ("app/testpmd: add port reset command") > Cc: sta...@dpdk.org > > Signed-off-by: Wang ShougangX