Re: [dpdk-dev] [dpdk-dev v4 1/4] cryptodev: add symmetric crypto data-path APIs

2020-07-08 Thread Zhang, Roy Fan
Hi Akhil, Thanks for the comments! > -Original Message- > From: Akhil Goyal > Sent: Tuesday, July 7, 2020 9:37 PM > To: Zhang, Roy Fan ; dev@dpdk.org; > ano...@marvell.com; asoma...@amd.com; ruifeng.w...@arm.com; > Nagadheeraj Rottela ; Michael Shamis > ; Ankur Dwivedi ; Jay > Zhou ; De

Re: [dpdk-dev] [dpdk-dev v4 1/4] cryptodev: add symmetric crypto data-path APIs

2020-07-07 Thread Akhil Goyal
Hi Fan, > > Hi Akhil, > > ... > > > > > > As you may have seen the structure definition is hW centric with the > > > IOVA addresses all over. Also as you will from the patch series the > > operation is > > > Per operation basis instead of operating in a burst. The external > > > application > >

Re: [dpdk-dev] [dpdk-dev v4 1/4] cryptodev: add symmetric crypto data-path APIs

2020-07-07 Thread Zhang, Roy Fan
Hi Akhil, > -Original Message- > From: Akhil Goyal > Sent: Monday, July 6, 2020 1:13 PM > To: Zhang, Roy Fan ; dev@dpdk.org; > ano...@marvell.com; asoma...@amd.com; ruifeng.w...@arm.com; > Nagadheeraj Rottela ; Michael Shamis > ; Ankur Dwivedi ; Jay > Zhou ; De Lara Guarch, Pablo > > Cc:

Re: [dpdk-dev] [dpdk-dev v4 1/4] cryptodev: add symmetric crypto data-path APIs

2020-07-06 Thread Akhil Goyal
Hi Fan, > Hi Akhil, > > > > + > > > +/** > > > + * Asynchronous operation job descriptor. > > > + * Used by HW crypto devices direct API call that supports such activity > > > + **/ > > > +struct rte_crypto_sym_job { > > > + union { > > > + /** > > > + * When RTE_CRYPTO_HW_ENQ_FL

Re: [dpdk-dev] [dpdk-dev v4 1/4] cryptodev: add symmetric crypto data-path APIs

2020-07-06 Thread Zhang, Roy Fan
Hi Akhil, > -Original Message- > From: Akhil Goyal > Sent: Saturday, July 4, 2020 7:16 PM > To: Zhang, Roy Fan ; dev@dpdk.org; > ano...@marvell.com; asoma...@amd.com; ruifeng.w...@arm.com; > Nagadheeraj Rottela ; Michael Shamis > ; Ankur Dwivedi ; Jay > Zhou ; De Lara Guarch, Pablo > > C

Re: [dpdk-dev] [dpdk-dev v4 1/4] cryptodev: add symmetric crypto data-path APIs

2020-07-04 Thread Akhil Goyal
Hi Fan, > + > +/** > + * Asynchronous operation job descriptor. > + * Used by HW crypto devices direct API call that supports such activity > + **/ > +struct rte_crypto_sym_job { > + union { > + /** > + * When RTE_CRYPTO_HW_ENQ_FLAG_IS_SGL bit is set in flags, > sgl >

[dpdk-dev] [dpdk-dev v4 1/4] cryptodev: add symmetric crypto data-path APIs

2020-07-03 Thread Fan Zhang
This patch adds data-path APIs to cryptodev. The APIs are organized as a data structure containing function pointers for different enqueue and dequeue operations. An added public API is added to obtain the function pointers and necessary queue pair data from the device queue pair. This patch depen