Re: [dpdk-dev] [Suspected-Phishing][PATCH v3] net/mlx5: support IP-in-IP tunnel

2019-07-10 Thread Jack Min
va > > > -Original Message- > > From: dev On Behalf Of Slava Ovsiienko > > Sent: Wednesday, July 10, 2019 17:20 > > To: Jack Min ; Raslan Darawsheh > > ; Shahaf Shuler ; > > Yongseok Koh ; John McNamara > > ; Marko Kovacevic > > > >

Re: [dpdk-dev] [Suspected-Phishing][PATCH v3] net/mlx5: support IP-in-IP tunnel

2019-07-10 Thread Slava Ovsiienko
gt; To: Jack Min ; Raslan Darawsheh > ; Shahaf Shuler ; > Yongseok Koh ; John McNamara > ; Marko Kovacevic > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [Suspected-Phishing][PATCH v3] net/mlx5: support > IP-in-IP tunnel > > Hi, Xiaoyu > > There is a couple of s

Re: [dpdk-dev] [Suspected-Phishing][PATCH v3] net/mlx5: support IP-in-IP tunnel

2019-07-10 Thread Slava Ovsiienko
Hi, Xiaoyu There is a couple of small points to note: 1) It would be good to have the testpmd flow create command sample with new tunnels in commit log. 2) is it OK: "mlx5_flow_tunnel_ip_check(items, &last_item); " ? It looks like a bug, should the second parameter be "&item_flags" ? (if so