Re: [dpdk-dev] [RFC v4 1/1] lib/compressdev: Adding hash support

2018-03-16 Thread Trahe, Fiona
Hi Shally, //snip//; > >> + /**< window size range in bytes */ > >> + int support_dict; > >> + /** Indicate algo support for dictionary load */ > >[Fiona] I need more info on this - What else is needed on the API to support > >it? > [Shally] We will need to add an API, say, rte_comp_set_dictio

Re: [dpdk-dev] [RFC v4 1/1] lib/compressdev: Adding hash support

2018-03-15 Thread Verma, Shally
Hi Fiona Thanks for feedback. Comments inline. >-Original Message- >From: Trahe, Fiona [mailto:fiona.tr...@intel.com] >Sent: 14 March 2018 18:12 >To: Verma, Shally >Cc: Athreya, Narayana Prasad ; Challa, >Mahipal ; Gupta, >Ashish ; dev@dpdk.org; ahmed.mans...@nxp.com; Trahe, >Fiona

Re: [dpdk-dev] [RFC v4 1/1] lib/compressdev: Adding hash support

2018-03-14 Thread Trahe, Fiona
Hi Shally, Sorry about the delay in responding. Comments below. If you want to push next update to github we can continue dev there. Regards, Fiona > -Original Message- > From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] > Sent: Thursday, February 1, 2018 11:07 AM > To: Trahe,

[dpdk-dev] [RFC v4 1/1] lib/compressdev: Adding hash support

2018-02-01 Thread Shally Verma
Added hash support in lib compressdev. It's an incremental patch to compression lib RFC v3 https://dpdk.org/dev/patchwork/patch/32331/ Changes from RFC v3: - Added hash algo enumeration and associated capability stucture and params in xform and rte_comp_op - Rearranged rte_compresdev_capability