Re: [dpdk-dev] [RFC v2, 2/2] eventdev: add crypto adapter API header

2018-03-05 Thread Akhil Goyal
Hi Narender, On 3/4/2018 4:12 AM, Vangati, Narender wrote: Akhil, I'm probably missing a point somewhere but I don't follow the suggestions. To me, ethdev, cryptodev, eventdev, etc. are device abstractions, whereas the proposed ENQ mode isn't at the same level. The DEQ mode is a device abstract

Re: [dpdk-dev] [RFC v2, 2/2] eventdev: add crypto adapter API header

2018-03-05 Thread Akhil Goyal
Hi Abhinandan, Sorry for the delayed response, my office network had some issues wrt NNTP, so couldn't reply. On 2/28/2018 2:31 PM, Gujjar, Abhinandan S wrote: Hi Akhil, .. + * crypto operation directly to cryptodev or send it to the + cryptodev + * adapter via eventdev, the crypt

Re: [dpdk-dev] [RFC v2, 2/2] eventdev: add crypto adapter API header

2018-03-03 Thread Vangati, Narender
Akhil, I'm probably missing a point somewhere but I don't follow the suggestions. To me, ethdev, cryptodev, eventdev, etc. are device abstractions, whereas the proposed ENQ mode isn't at the same level. The DEQ mode is a device abstraction for cryptodev->eventdev (whether h/w or s/w based), but

Re: [dpdk-dev] [RFC v2, 2/2] eventdev: add crypto adapter API header

2018-02-28 Thread Gujjar, Abhinandan S
Hi Akhil, > -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Monday, February 26, 2018 7:22 PM > To: Jerin Jacob ; Gujjar, Abhinandan S > > Cc: dev@dpdk.org; Vangati, Narender ; Rao, > Nikhil ; Eads, Gage ; > hemant.agra...@nxp.com; narayanaprasad.athr...@cavium

Re: [dpdk-dev] [RFC v2, 2/2] eventdev: add crypto adapter API header

2018-02-26 Thread Akhil Goyal
Hi Jerin/Abhinandan, On 2/20/2018 7:29 PM, Jerin Jacob wrote: -Original Message- Date: Mon, 19 Feb 2018 10:55:58 + From: "Gujjar, Abhinandan S" To: Jerin Jacob CC: "dev@dpdk.org" , "Vangati, Narender" , "Rao, Nikhil" , "Eads, Gage" , "hemant.agra...@nxp.com" , "akhil.go...@n

Re: [dpdk-dev] [RFC v2, 2/2] eventdev: add crypto adapter API header

2018-02-23 Thread Akhil Goyal
Hi Folks, On 2/20/2018 7:29 PM, Jerin Jacob wrote: -Original Message- Date: Mon, 19 Feb 2018 10:55:58 + From: "Gujjar, Abhinandan S" To: Jerin Jacob CC: "dev@dpdk.org" , "Vangati, Narender" , "Rao, Nikhil" , "Eads, Gage" , "hemant.agra...@nxp.com" , "akhil.go...@nxp.com" ,

Re: [dpdk-dev] [RFC v2, 2/2] eventdev: add crypto adapter API header

2018-02-20 Thread Jerin Jacob
-Original Message- > Date: Tue, 20 Feb 2018 18:55:09 + > From: "Vangati, Narender" > To: Jerin Jacob , "Gujjar, Abhinandan S" > > CC: "dev@dpdk.org" , "Rao, Nikhil" , > "Eads, Gage" , "hemant.agra...@nxp.com" > , "akhil.go...@nxp.com" , > "narayanaprasad.athr...@cavium.com" , > "

Re: [dpdk-dev] [RFC v2, 2/2] eventdev: add crypto adapter API header

2018-02-20 Thread Vangati, Narender
Jerin, I see the "ENQ" part of the adapter a little differently. I think there is value to offloading cryptodev_enqueue to an adapter service, even when the h/w natively supports DEQ. When the same queue pair is being used by the workers to enqueue requests (this could be where the pre crypto s

Re: [dpdk-dev] [RFC v2, 2/2] eventdev: add crypto adapter API header

2018-02-20 Thread Jerin Jacob
-Original Message- > Date: Mon, 19 Feb 2018 10:55:58 + > From: "Gujjar, Abhinandan S" > To: Jerin Jacob > CC: "dev@dpdk.org" , "Vangati, Narender" > , "Rao, Nikhil" , "Eads, > Gage" , "hemant.agra...@nxp.com" > , "akhil.go...@nxp.com" , > "narayanaprasad.athr...@cavium.com" , > "

Re: [dpdk-dev] [RFC v2, 2/2] eventdev: add crypto adapter API header

2018-02-19 Thread Gujjar, Abhinandan S
Hi Jerin, Thanks for the review. Please find few comments inline. > -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Saturday, February 17, 2018 1:04 AM > To: Gujjar, Abhinandan S > Cc: dev@dpdk.org; Vangati, Narender ; Rao, > Nikhil ; Eads, Gage ; >

Re: [dpdk-dev] [RFC v2, 2/2] eventdev: add crypto adapter API header

2018-02-16 Thread Jerin Jacob
-Original Message- > Date: Mon, 15 Jan 2018 16:23:50 +0530 > From: Abhinandan Gujjar > To: jerin.ja...@caviumnetworks.com > CC: dev@dpdk.org, narender.vang...@intel.com, Abhinandan Gujjar > , Nikhil Rao , Gage > Eads > Subject: [RFC v2, 2/2] eventdev: add crypto adapter API header > X-M

Re: [dpdk-dev] [RFC v2, 2/2] eventdev: add crypto adapter API header

2018-02-13 Thread Gujjar, Abhinandan S
A gentle remainder for review :) -Abhinandan > -Original Message- > From: Gujjar, Abhinandan S > Sent: Monday, January 15, 2018 4:24 PM > To: jerin.ja...@caviumnetworks.com > Cc: dev@dpdk.org; Vangati, Narender ; Gujjar, > Abhinandan S ; Rao, Nikhil > ; Eads, Gage > Subject: [RFC v2, 2/2

[dpdk-dev] [RFC v2, 2/2] eventdev: add crypto adapter API header

2018-01-15 Thread Abhinandan Gujjar
Add crypto event adapter APIs to support packet transfer mechanism between cryptodev and event device. Signed-off-by: Abhinandan Gujjar Signed-off-by: Nikhil Rao Signed-off-by: Gage Eads --- Notes: V2: 1. Updated type as ENQ-DEQ in rte_event_crypto_adapter_type 2. Remove