Re: [dpdk-dev] [RFC PATCH] mbuf: move headers not fragmented check to checksum

2019-02-13 Thread Ananyev, Konstantin
Hi Andrew, > rte_validate_tx_offload() is used in Tx prepare callbacks > (RTE_LIBRTE_ETHDEV_DEBUG only) to check Tx offloads consistency. > Requirement that packet headers should not be fragmented is not > documented and unclear where it comes from except > rte_net_intel_cksum_prepare() functio

Re: [dpdk-dev] [RFC PATCH] mbuf: move headers not fragmented check to checksum

2019-02-13 Thread Wiles, Keith
> On Feb 13, 2019, at 3:50 AM, Andrew Rybchenko > wrote: > > Ping. > > Do 2 weeks without reply mean that it looks good and I should send non-RCF > version? Just send the non-RFC patch as it seems most do not even look at the RFC’s anyway. > > Andrew. > > On 1/29/19 11:49 AM, Andrew Rybc

Re: [dpdk-dev] [RFC PATCH] mbuf: move headers not fragmented check to checksum

2019-02-13 Thread Andrew Rybchenko
Ping. Do 2 weeks without reply mean that it looks good and I should send non-RCF version? Andrew. On 1/29/19 11:49 AM, Andrew Rybchenko wrote: rte_validate_tx_offload() is used in Tx prepare callbacks (RTE_LIBRTE_ETHDEV_DEBUG only) to check Tx offloads consistency. Requirement that packet he

[dpdk-dev] [RFC PATCH] mbuf: move headers not fragmented check to checksum

2019-01-29 Thread Andrew Rybchenko
rte_validate_tx_offload() is used in Tx prepare callbacks (RTE_LIBRTE_ETHDEV_DEBUG only) to check Tx offloads consistency. Requirement that packet headers should not be fragmented is not documented and unclear where it comes from except rte_net_intel_cksum_prepare() functions which relies on it. I