Re: [dpdk-dev] [RFC PATCH] bus/pci: avoid depending on private value in kernel source

2019-07-03 Thread Tiwei Bie
On Wed, Jul 03, 2019 at 11:10:21AM +0200, David Marchand wrote: > > On Wed, Jul 3, 2019 at 11:01 AM Tiwei Bie wrote: > > On Wed, Jul 03, 2019 at 10:26:39AM +0200, David Marchand wrote: > > This patch breaks the ABI by extending rte_pci_device. > > You must rework it to avoid this bre

Re: [dpdk-dev] [RFC PATCH] bus/pci: avoid depending on private value in kernel source

2019-07-03 Thread David Marchand
On Wed, Jul 3, 2019 at 11:01 AM Tiwei Bie wrote: > On Wed, Jul 03, 2019 at 10:26:39AM +0200, David Marchand wrote: > > This patch breaks the ABI by extending rte_pci_device. > > You must rework it to avoid this break. > > I didn't expect it to be merged in this release. I just want > to draw othe

Re: [dpdk-dev] [RFC PATCH] bus/pci: avoid depending on private value in kernel source

2019-07-03 Thread Tiwei Bie
On Wed, Jul 03, 2019 at 10:26:39AM +0200, David Marchand wrote: > On Wed, Jul 3, 2019 at 10:17 AM Tiwei Bie wrote: > > On Wed, Jul 03, 2019 at 10:01:44AM +0200, David Marchand wrote: > > On Wed, Jul 3, 2019 at 9:58 AM Tiwei Bie wrote: > > > > On Wed, Jul 03, 2019 at 09:36:26A

Re: [dpdk-dev] [RFC PATCH] bus/pci: avoid depending on private value in kernel source

2019-07-03 Thread David Marchand
On Wed, Jul 3, 2019 at 10:17 AM Tiwei Bie wrote: > On Wed, Jul 03, 2019 at 10:01:44AM +0200, David Marchand wrote: > > On Wed, Jul 3, 2019 at 9:58 AM Tiwei Bie wrote: > > > > On Wed, Jul 03, 2019 at 09:36:26AM +0200, David Marchand wrote: > > > On Wed, Jul 3, 2019 at 9:35 AM Tiwei Bie >

Re: [dpdk-dev] [RFC PATCH] bus/pci: avoid depending on private value in kernel source

2019-07-03 Thread Tiwei Bie
On Wed, Jul 03, 2019 at 10:01:44AM +0200, David Marchand wrote: > On Wed, Jul 3, 2019 at 9:58 AM Tiwei Bie wrote: > > On Wed, Jul 03, 2019 at 09:36:26AM +0200, David Marchand wrote: > > On Wed, Jul 3, 2019 at 9:35 AM Tiwei Bie wrote: > > > > Hi David, > > > > On W

Re: [dpdk-dev] [RFC PATCH] bus/pci: avoid depending on private value in kernel source

2019-07-03 Thread David Marchand
On Wed, Jul 3, 2019 at 9:58 AM Tiwei Bie wrote: > On Wed, Jul 03, 2019 at 09:36:26AM +0200, David Marchand wrote: > > On Wed, Jul 3, 2019 at 9:35 AM Tiwei Bie wrote: > > > > Hi David, > > > > On Wed, Jul 03, 2019 at 09:02:59AM +0200, David Marchand wrote: > > > Hello, > > > > >

Re: [dpdk-dev] [RFC PATCH] bus/pci: avoid depending on private value in kernel source

2019-07-03 Thread Tiwei Bie
On Wed, Jul 03, 2019 at 09:36:26AM +0200, David Marchand wrote: > On Wed, Jul 3, 2019 at 9:35 AM Tiwei Bie wrote: > > Hi David, > > On Wed, Jul 03, 2019 at 09:02:59AM +0200, David Marchand wrote: > > Hello, > > > > On Wed, Jul 3, 2019 at 7:47 AM Tiwei Bie wrote: > > >

Re: [dpdk-dev] [RFC PATCH] bus/pci: avoid depending on private value in kernel source

2019-07-03 Thread David Marchand
On Wed, Jul 3, 2019 at 9:35 AM Tiwei Bie wrote: > Hi David, > > On Wed, Jul 03, 2019 at 09:02:59AM +0200, David Marchand wrote: > > Hello, > > > > On Wed, Jul 3, 2019 at 7:47 AM Tiwei Bie wrote: > > > > The value 40 used in VFIO_GET_REGION_ADDR() is a private value > > (VFIO_PCI_OFFSET_S

Re: [dpdk-dev] [RFC PATCH] bus/pci: avoid depending on private value in kernel source

2019-07-03 Thread Tiwei Bie
Hi David, On Wed, Jul 03, 2019 at 09:02:59AM +0200, David Marchand wrote: > Hello, > > On Wed, Jul 3, 2019 at 7:47 AM Tiwei Bie wrote: > > The value 40 used in VFIO_GET_REGION_ADDR() is a private value > (VFIO_PCI_OFFSET_SHIFT) defined in Linux kernel source [1]. It > is not part of

Re: [dpdk-dev] [RFC PATCH] bus/pci: avoid depending on private value in kernel source

2019-07-03 Thread David Marchand
Hello, On Wed, Jul 3, 2019 at 7:47 AM Tiwei Bie wrote: > The value 40 used in VFIO_GET_REGION_ADDR() is a private value > (VFIO_PCI_OFFSET_SHIFT) defined in Linux kernel source [1]. It > is not part of VFIO API, and we should not depend on it. > > [1] > https://github.com/torvalds/linux/blob/6fb

[dpdk-dev] [RFC PATCH] bus/pci: avoid depending on private value in kernel source

2019-07-02 Thread Tiwei Bie
The value 40 used in VFIO_GET_REGION_ADDR() is a private value (VFIO_PCI_OFFSET_SHIFT) defined in Linux kernel source [1]. It is not part of VFIO API, and we should not depend on it. [1] https://github.com/torvalds/linux/blob/6fbc7275c7a9/drivers/vfio/pci/vfio_pci_private.h#L19 Signed-off-by: Ti