Re: [dpdk-dev] [RFC 2/2] nfp: allow for non-root user

2018-04-18 Thread Alejandro Lucero
On Wed, Apr 18, 2018 at 1:32 PM, Aaron Conole wrote: > Alejandro Lucero writes: > > > On Tue, Apr 17, 2018 at 8:19 PM, Aaron Conole > wrote: > > > > Alejandro Lucero writes: > > > > > I was just wondering, if device device PCI sysfs resource files or > VFIO group /dev files > > require to c

Re: [dpdk-dev] [RFC 2/2] nfp: allow for non-root user

2018-04-18 Thread Aaron Conole
Alejandro Lucero writes: > On Tue, Apr 17, 2018 at 8:19 PM, Aaron Conole wrote: > > Alejandro Lucero writes: > > > I was just wondering, if device device PCI sysfs resource files or VFIO > group /dev files > require to change > > permissions for non-root users, does it not make sense to ad

Re: [dpdk-dev] [RFC 2/2] nfp: allow for non-root user

2018-04-18 Thread Alejandro Lucero
On Tue, Apr 17, 2018 at 8:19 PM, Aaron Conole wrote: > Alejandro Lucero writes: > > > I was just wondering, if device device PCI sysfs resource files or VFIO > group /dev files require to change > > permissions for non-root users, does it not make sense to adjust also > /var/lock in the system?

Re: [dpdk-dev] [RFC 2/2] nfp: allow for non-root user

2018-04-17 Thread Aaron Conole
Alejandro Lucero writes: > I was just wondering, if device device PCI sysfs resource files or VFIO group > /dev files require to change > permissions for non-root users, does it not make sense to adjust also > /var/lock in the system? For the /dev, we use udev rules - so the correct individual

Re: [dpdk-dev] [RFC 2/2] nfp: allow for non-root user

2018-04-17 Thread Thomas Monjalon
17/04/2018 18:24, Alejandro Lucero: > On Tue, Apr 17, 2018 at 4:54 PM, Thomas Monjalon > wrote: > > > 17/04/2018 17:44, Alejandro Lucero: > > > Adding stable@ and Thomas for discussing how can this be added to stable > > > DPDK versions even if this is not going to be a patch for current DPDK > >

Re: [dpdk-dev] [RFC 2/2] nfp: allow for non-root user

2018-04-17 Thread Alejandro Lucero
On Tue, Apr 17, 2018 at 4:54 PM, Thomas Monjalon wrote: > 17/04/2018 17:44, Alejandro Lucero: > > Adding stable@ and Thomas for discussing how can this be added to stable > > DPDK versions even if this is not going to be a patch for current DPDK > > version. > > I don't understand. > This patch w

Re: [dpdk-dev] [RFC 2/2] nfp: allow for non-root user

2018-04-17 Thread Thomas Monjalon
17/04/2018 17:44, Alejandro Lucero: > Adding stable@ and Thomas for discussing how can this be added to stable > DPDK versions even if this is not going to be a patch for current DPDK > version. I don't understand. This patch won't enter in 18.05? Why do you think this patch is candidate for stabl

Re: [dpdk-dev] [RFC 2/2] nfp: allow for non-root user

2018-04-17 Thread Alejandro Lucero
I was just wondering, if device device PCI sysfs resource files or VFIO group /dev files require to change permissions for non-root users, does it not make sense to adjust also /var/lock in the system? On Tue, Apr 17, 2018 at 4:44 PM, Alejandro Lucero < alejandro.luc...@netronome.com> wrote: >

Re: [dpdk-dev] [RFC 2/2] nfp: allow for non-root user

2018-04-17 Thread Alejandro Lucero
I have seen that VFIO also requires explicitly to set the right permissions for non-root users to VFIO groups under /dev/vfio. I assume then that running OVS or other DPDK apps as non-root is possible, although requiring those explicit permissions changes, and therefore this patch is necessary. A

Re: [dpdk-dev] [RFC 2/2] nfp: allow for non-root user

2018-04-13 Thread Alejandro Lucero
On Fri, Apr 13, 2018 at 2:31 PM, Aaron Conole wrote: > Alejandro Lucero writes: > > > Again, this patch is correct, but because NFP PMD needs to access > > /sys/bus/pci/devices/$DEVICE_PCI_STRING/resource$RESOURCE_ID, and these > files have just > > read/write accesses for root, I do not know if

Re: [dpdk-dev] [RFC 2/2] nfp: allow for non-root user

2018-04-13 Thread Aaron Conole
Alejandro Lucero writes: > Again, this patch is correct, but because NFP PMD needs to access > /sys/bus/pci/devices/$DEVICE_PCI_STRING/resource$RESOURCE_ID, and these files > have just > read/write accesses for root, I do not know if this is really necessary. > > Being honest, I have not used a

Re: [dpdk-dev] [RFC 2/2] nfp: allow for non-root user

2018-04-13 Thread Alejandro Lucero
Again, this patch is correct, but because NFP PMD needs to access /sys/bus/pci/devices/$DEVICE_PCI_STRING/resource$RESOURCE_ID, and these files have just read/write accesses for root, I do not know if this is really necessary. Being honest, I have not used a DPDK app with NFP PMD and not being roo

[dpdk-dev] [RFC 2/2] nfp: allow for non-root user

2018-04-12 Thread Aaron Conole
Currently, the nfp lock files are taken from the global lock file location, which will work when the user is running as root. However, some distributions and applications (notably ovs 2.8+ on RHEL/Fedora) run as a non-root user. Signed-off-by: Aaron Conole --- drivers/net/nfp/nfp_nfpu.c | 23 ++