Re: [dpdk-dev] [RFC 17.05] test: move tests to separate folder

2017-02-15 Thread Ferruh Yigit
On 2/15/2017 11:16 AM, Thomas Monjalon wrote: > 2017-02-15 10:06, Ferruh Yigit: >> On 2/15/2017 2:11 AM, Yuanhan Liu wrote: >>> On Tue, Feb 14, 2017 at 05:30:14PM +, Richardson, Bruce wrote: Just to be awkward :-), one last question: Why separate building and running the tests?

Re: [dpdk-dev] [RFC 17.05] test: move tests to separate folder

2017-02-15 Thread Thomas Monjalon
2017-02-15 10:06, Ferruh Yigit: > On 2/15/2017 2:11 AM, Yuanhan Liu wrote: > > On Tue, Feb 14, 2017 at 05:30:14PM +, Richardson, Bruce wrote: > >> Just to be awkward :-), one last question: Why separate building and > >> running > >> the tests? My suggestion would be to have "make test" both b

Re: [dpdk-dev] [RFC 17.05] test: move tests to separate folder

2017-02-15 Thread Ferruh Yigit
On 2/15/2017 2:11 AM, Yuanhan Liu wrote: > On Tue, Feb 14, 2017 at 05:30:14PM +, Richardson, Bruce wrote: >> Just to be awkward :-), one last question: Why separate building and running >> the tests? My suggestion would be to have "make test" both build and run the >> tests. If there is no work

Re: [dpdk-dev] [RFC 17.05] test: move tests to separate folder

2017-02-15 Thread Thomas Monjalon
2017-02-14 16:12, Mcnamara, John: > It is probably more important that the user runs the tests than just > compiles them. :-) As a side effect of running the tests they will > also compile them. > > As a side issue I think that we should improve the ease of running and > extending the test suite.

Re: [dpdk-dev] [RFC 17.05] test: move tests to separate folder

2017-02-14 Thread Yuanhan Liu
On Tue, Feb 14, 2017 at 05:30:14PM +, Richardson, Bruce wrote: > Just to be awkward :-), one last question: Why separate building and running > the tests? My suggestion would be to have "make test" both build and run the > tests. If there is no work to do in building them, then the time cost of

Re: [dpdk-dev] [RFC 17.05] test: move tests to separate folder

2017-02-14 Thread Richardson, Bruce
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, February 14, 2017 5:07 PM > To: Richardson, Bruce > Cc: Thomas Monjalon ; dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC 17.05] test: move tests to separate folder > > On 2/14/2017 3:41 PM, Bruce Richardso

Re: [dpdk-dev] [RFC 17.05] test: move tests to separate folder

2017-02-14 Thread Ferruh Yigit
On 2/14/2017 3:41 PM, Bruce Richardson wrote: > On Tue, Feb 14, 2017 at 03:13:26PM +, Ferruh Yigit wrote: >> Tests are part of app folder and compiled with library every time. >> Moving tests into a "test" folder which won't be compiled by default. >> To compile tests, need to give explicit "ma

Re: [dpdk-dev] [RFC 17.05] test: move tests to separate folder

2017-02-14 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Tuesday, February 14, 2017 3:13 PM > To: Thomas Monjalon > Cc: dev@dpdk.org; Yigit, Ferruh > Subject: [dpdk-dev] [RFC 17.05] test: move tests to separate folder > &g

Re: [dpdk-dev] [RFC 17.05] test: move tests to separate folder

2017-02-14 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Tuesday, February 14, 2017 3:42 PM > To: Yigit, Ferruh > Cc: Thomas Monjalon ; dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC 17.05] test: move tests to separate folder &

Re: [dpdk-dev] [RFC 17.05] test: move tests to separate folder

2017-02-14 Thread Wiles, Keith
> On Feb 14, 2017, at 9:41 AM, Bruce Richardson > wrote: > > On Tue, Feb 14, 2017 at 03:13:26PM +, Ferruh Yigit wrote: >> Tests are part of app folder and compiled with library every time. >> Moving tests into a "test" folder which won't be compiled by default. >> To compile tests, need to

Re: [dpdk-dev] [RFC 17.05] test: move tests to separate folder

2017-02-14 Thread Bruce Richardson
On Tue, Feb 14, 2017 at 03:13:26PM +, Ferruh Yigit wrote: > Tests are part of app folder and compiled with library every time. > Moving tests into a "test" folder which won't be compiled by default. > To compile tests, need to give explicit "make test" command. > > "make test" was previously u

[dpdk-dev] [RFC 17.05] test: move tests to separate folder

2017-02-14 Thread Ferruh Yigit
Tests are part of app folder and compiled with library every time. Moving tests into a "test" folder which won't be compiled by default. To compile tests, need to give explicit "make test" command. "make test" was previously used to run tests, which renamed to "make test_run" with this patch. Thi