Re: [dpdk-dev] [RFC 1/4] mempool: clarify default populate function

2019-10-08 Thread Olivier Matz
On Fri, Jul 19, 2019 at 06:42:06PM +0300, Andrew Rybchenko wrote: > On 7/19/19 4:38 PM, Olivier Matz wrote: > > No functional change. Clarify the populate function to make > > the next commit easier to understand. > > > > Rename the variables: > > - to avoid negation in the name > > - to have more

Re: [dpdk-dev] [RFC 1/4] mempool: clarify default populate function

2019-07-19 Thread Andrew Rybchenko
On 7/19/19 4:38 PM, Olivier Matz wrote: No functional change. Clarify the populate function to make the next commit easier to understand. Rename the variables: - to avoid negation in the name - to have more understandable names Remove useless variable (no_pageshift is equivalent to pg_sz == 0).

[dpdk-dev] [RFC 1/4] mempool: clarify default populate function

2019-07-19 Thread Olivier Matz
No functional change. Clarify the populate function to make the next commit easier to understand. Rename the variables: - to avoid negation in the name - to have more understandable names Remove useless variable (no_pageshift is equivalent to pg_sz == 0). Remove duplicate affectation of "externa