Re: [dpdk-dev] [RFC 1/2] ethdev: move queue stats to xstats

2020-10-13 Thread Ferruh Yigit
On 10/12/2020 10:53 PM, Thomas Monjalon wrote: 12/10/2020 18:46, Ferruh Yigit: Queue stats are stored in 'struct rte_eth_stats' as array and array size is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag. As a result of technical board discussion, decided to remove the queue statistic

Re: [dpdk-dev] [RFC 1/2] ethdev: move queue stats to xstats

2020-10-13 Thread Ferruh Yigit
On 10/13/2020 10:16 AM, Andrew Rybchenko wrote: On 10/13/20 12:05 PM, Thomas Monjalon wrote: 13/10/2020 10:31, Andrew Rybchenko: On 10/13/20 12:53 AM, Thomas Monjalon wrote: 12/10/2020 18:46, Ferruh Yigit: Queue stats are stored in 'struct rte_eth_stats' as array and array size is defined by

Re: [dpdk-dev] [RFC 1/2] ethdev: move queue stats to xstats

2020-10-13 Thread Stephen Hemminger
On Tue, 13 Oct 2020 11:05:07 +0200 Thomas Monjalon wrote: > 13/10/2020 10:31, Andrew Rybchenko: > > On 10/13/20 12:53 AM, Thomas Monjalon wrote: > > > 12/10/2020 18:46, Ferruh Yigit: > > >> Queue stats are stored in 'struct rte_eth_stats' as array and array size > > >> is defined by 'RTE_ETHD

Re: [dpdk-dev] [RFC 1/2] ethdev: move queue stats to xstats

2020-10-13 Thread Andrew Rybchenko
On 10/13/20 12:05 PM, Thomas Monjalon wrote: > 13/10/2020 10:31, Andrew Rybchenko: >> On 10/13/20 12:53 AM, Thomas Monjalon wrote: >>> 12/10/2020 18:46, Ferruh Yigit: Queue stats are stored in 'struct rte_eth_stats' as array and array size is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compi

Re: [dpdk-dev] [RFC 1/2] ethdev: move queue stats to xstats

2020-10-13 Thread Thomas Monjalon
13/10/2020 10:31, Andrew Rybchenko: > On 10/13/20 12:53 AM, Thomas Monjalon wrote: > > 12/10/2020 18:46, Ferruh Yigit: > >> Queue stats are stored in 'struct rte_eth_stats' as array and array size > >> is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag. > >> > >> As a result of technical

Re: [dpdk-dev] [RFC 1/2] ethdev: move queue stats to xstats

2020-10-13 Thread Andrew Rybchenko
On 10/13/20 12:53 AM, Thomas Monjalon wrote: > 12/10/2020 18:46, Ferruh Yigit: >> Queue stats are stored in 'struct rte_eth_stats' as array and array size >> is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag. >> >> As a result of technical board discussion, decided to remove the queue >

Re: [dpdk-dev] [RFC 1/2] ethdev: move queue stats to xstats

2020-10-12 Thread Thomas Monjalon
12/10/2020 18:46, Ferruh Yigit: > Queue stats are stored in 'struct rte_eth_stats' as array and array size > is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag. > > As a result of technical board discussion, decided to remove the queue > statistics from 'struct rte_eth_stats' in the lon

[dpdk-dev] [RFC 1/2] ethdev: move queue stats to xstats

2020-10-12 Thread Ferruh Yigit
Queue stats are stored in 'struct rte_eth_stats' as array and array size is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag. As a result of technical board discussion, decided to remove the queue statistics from 'struct rte_eth_stats' in the long term. Instead PMDs should represent the