Re: [dpdk-dev] [RFC] net: be more restrictive in ether_unformat_addr

2019-07-18 Thread Stephen Hemminger
On Thu, 18 Jul 2019 09:47:03 +0200 Olivier Matz wrote: > Hi, > > I'm fine with a more strict version like you proposed here. I checked > that the cmdline tests pass. > > Few minor comments below. > > On Wed, Jul 17, 2019 at 11:49:45AM -0700, Stephen Hemminger wrote: > > The current code acts m

Re: [dpdk-dev] [RFC] net: be more restrictive in ether_unformat_addr

2019-07-18 Thread Olivier Matz
Hi, I'm fine with a more strict version like you proposed here. I checked that the cmdline tests pass. Few minor comments below. On Wed, Jul 17, 2019 at 11:49:45AM -0700, Stephen Hemminger wrote: > The current code acts more like BSD ether_aton and allows leading zeros > which breaks the cmdline

[dpdk-dev] [RFC] net: be more restrictive in ether_unformat_addr

2019-07-17 Thread Stephen Hemminger
The current code acts more like BSD ether_aton and allows leading zeros which breaks the cmdline tests. Change the code to be more restrictive and only allow the fully expanded standard formats. Fixes: 596d31092d32 ("net: add function to convert string to ethernet address") Signed-off-by: Stephen