Re: [dpdk-dev] [RFC] net/null: add empty promiscuous mode functions

2019-10-18 Thread Ferruh Yigit
On 10/18/2019 2:12 PM, Bruce Richardson wrote: > On Fri, Oct 18, 2019 at 12:38:53PM +0100, Ferruh Yigit wrote: >> On 10/18/2019 11:13 AM, Bruce Richardson wrote: >>> On Thu, Oct 17, 2019 at 04:33:59PM +0100, Ferruh Yigit wrote: On 10/17/2019 2:43 PM, Bruce Richardson wrote: > On Thu, Oct 1

Re: [dpdk-dev] [RFC] net/null: add empty promiscuous mode functions

2019-10-18 Thread Bruce Richardson
On Fri, Oct 18, 2019 at 12:38:53PM +0100, Ferruh Yigit wrote: > On 10/18/2019 11:13 AM, Bruce Richardson wrote: > > On Thu, Oct 17, 2019 at 04:33:59PM +0100, Ferruh Yigit wrote: > >> On 10/17/2019 2:43 PM, Bruce Richardson wrote: > >>> On Thu, Oct 17, 2019 at 12:05:56PM +0100, Ferruh Yigit wrote: >

Re: [dpdk-dev] [RFC] net/null: add empty promiscuous mode functions

2019-10-18 Thread Ferruh Yigit
On 10/18/2019 12:57 PM, Andrew Rybchenko wrote: > On 10/18/19 2:38 PM, Ferruh Yigit wrote: >> On 10/18/2019 11:13 AM, Bruce Richardson wrote: >>> On Thu, Oct 17, 2019 at 04:33:59PM +0100, Ferruh Yigit wrote: On 10/17/2019 2:43 PM, Bruce Richardson wrote: > On Thu, Oct 17, 2019 at 12:05:56P

Re: [dpdk-dev] [RFC] net/null: add empty promiscuous mode functions

2019-10-18 Thread Andrew Rybchenko
On 10/18/19 2:38 PM, Ferruh Yigit wrote: On 10/18/2019 11:13 AM, Bruce Richardson wrote: On Thu, Oct 17, 2019 at 04:33:59PM +0100, Ferruh Yigit wrote: On 10/17/2019 2:43 PM, Bruce Richardson wrote: On Thu, Oct 17, 2019 at 12:05:56PM +0100, Ferruh Yigit wrote: On 10/17/2019 11:51 AM, Andrew Ry

Re: [dpdk-dev] [RFC] net/null: add empty promiscuous mode functions

2019-10-18 Thread Ferruh Yigit
On 10/18/2019 11:13 AM, Bruce Richardson wrote: > On Thu, Oct 17, 2019 at 04:33:59PM +0100, Ferruh Yigit wrote: >> On 10/17/2019 2:43 PM, Bruce Richardson wrote: >>> On Thu, Oct 17, 2019 at 12:05:56PM +0100, Ferruh Yigit wrote: On 10/17/2019 11:51 AM, Andrew Rybchenko wrote: > On 10/17/19

Re: [dpdk-dev] [RFC] net/null: add empty promiscuous mode functions

2019-10-18 Thread Bruce Richardson
On Thu, Oct 17, 2019 at 04:33:59PM +0100, Ferruh Yigit wrote: > On 10/17/2019 2:43 PM, Bruce Richardson wrote: > > On Thu, Oct 17, 2019 at 12:05:56PM +0100, Ferruh Yigit wrote: > >> On 10/17/2019 11:51 AM, Andrew Rybchenko wrote: > >>> On 10/17/19 1:47 PM, Ferruh Yigit wrote: > On 10/17/2019 1

Re: [dpdk-dev] [RFC] net/null: add empty promiscuous mode functions

2019-10-18 Thread Andrew Rybchenko
On 10/18/19 11:18 AM, Ferruh Yigit wrote: On 10/17/2019 4:33 PM, Ferruh Yigit wrote: On 10/17/2019 2:43 PM, Bruce Richardson wrote: On Thu, Oct 17, 2019 at 12:05:56PM +0100, Ferruh Yigit wrote: On 10/17/2019 11:51 AM, Andrew Rybchenko wrote: On 10/17/19 1:47 PM, Ferruh Yigit wrote: On 10/17/

Re: [dpdk-dev] [RFC] net/null: add empty promiscuous mode functions

2019-10-18 Thread Ferruh Yigit
On 10/17/2019 4:33 PM, Ferruh Yigit wrote: > On 10/17/2019 2:43 PM, Bruce Richardson wrote: >> On Thu, Oct 17, 2019 at 12:05:56PM +0100, Ferruh Yigit wrote: >>> On 10/17/2019 11:51 AM, Andrew Rybchenko wrote: On 10/17/19 1:47 PM, Ferruh Yigit wrote: > On 10/17/2019 11:37 AM, Andrew Rybchen

Re: [dpdk-dev] [RFC] net/null: add empty promiscuous mode functions

2019-10-17 Thread Ferruh Yigit
On 10/17/2019 2:43 PM, Bruce Richardson wrote: > On Thu, Oct 17, 2019 at 12:05:56PM +0100, Ferruh Yigit wrote: >> On 10/17/2019 11:51 AM, Andrew Rybchenko wrote: >>> On 10/17/19 1:47 PM, Ferruh Yigit wrote: On 10/17/2019 11:37 AM, Andrew Rybchenko wrote: > On 10/16/19 9:07 PM, Ferruh Yigit

Re: [dpdk-dev] [RFC] net/null: add empty promiscuous mode functions

2019-10-17 Thread Bruce Richardson
On Thu, Oct 17, 2019 at 12:05:56PM +0100, Ferruh Yigit wrote: > On 10/17/2019 11:51 AM, Andrew Rybchenko wrote: > > On 10/17/19 1:47 PM, Ferruh Yigit wrote: > >> On 10/17/2019 11:37 AM, Andrew Rybchenko wrote: > >>> On 10/16/19 9:07 PM, Ferruh Yigit wrote: > On 10/16/2019 4:46 PM, Ciara Power

Re: [dpdk-dev] [RFC] net/null: add empty promiscuous mode functions

2019-10-17 Thread Ferruh Yigit
On 10/17/2019 11:51 AM, Andrew Rybchenko wrote: > On 10/17/19 1:47 PM, Ferruh Yigit wrote: >> On 10/17/2019 11:37 AM, Andrew Rybchenko wrote: >>> On 10/16/19 9:07 PM, Ferruh Yigit wrote: On 10/16/2019 4:46 PM, Ciara Power wrote: > Adding promiscuous functions prevents sample applications f

Re: [dpdk-dev] [RFC] net/null: add empty promiscuous mode functions

2019-10-17 Thread Andrew Rybchenko
On 10/17/19 1:47 PM, Ferruh Yigit wrote: On 10/17/2019 11:37 AM, Andrew Rybchenko wrote: On 10/16/19 9:07 PM, Ferruh Yigit wrote: On 10/16/2019 4:46 PM, Ciara Power wrote: Adding promiscuous functions prevents sample applications failing when run on this virtual PMD. The sample applications ca

Re: [dpdk-dev] [RFC] net/null: add empty promiscuous mode functions

2019-10-17 Thread Ferruh Yigit
On 10/17/2019 11:37 AM, Andrew Rybchenko wrote: > On 10/16/19 9:07 PM, Ferruh Yigit wrote: >> On 10/16/2019 4:46 PM, Ciara Power wrote: >>> Adding promiscuous functions prevents sample applications failing when run >>> on this virtual PMD. The sample applications call promiscuous functions, >>> and

Re: [dpdk-dev] [RFC] net/null: add empty promiscuous mode functions

2019-10-17 Thread Andrew Rybchenko
On 10/16/19 9:07 PM, Ferruh Yigit wrote: On 10/16/2019 4:46 PM, Ciara Power wrote: Adding promiscuous functions prevents sample applications failing when run on this virtual PMD. The sample applications call promiscuous functions, and fail if this function call returns an error, which occurs whe

Re: [dpdk-dev] [RFC] net/null: add empty promiscuous mode functions

2019-10-16 Thread Ferruh Yigit
On 10/16/2019 4:46 PM, Ciara Power wrote: > Adding promiscuous functions prevents sample applications failing when run > on this virtual PMD. The sample applications call promiscuous functions, > and fail if this function call returns an error, which occurs when the > virtual PMD does not support t

[dpdk-dev] [RFC] net/null: add empty promiscuous mode functions

2019-10-16 Thread Ciara Power
Adding promiscuous functions prevents sample applications failing when run on this virtual PMD. The sample applications call promiscuous functions, and fail if this function call returns an error, which occurs when the virtual PMD does not support the promiscuous function being called. This chang