Re: [dpdk-dev] [RFC] net/ixgbe: fix Tx descriptor status api

2018-06-27 Thread Zhang, Qi Z
Hi Oliver > -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Tuesday, June 26, 2018 4:46 PM > To: Zhao1, Wei > Cc: Zhang, Qi Z ; dev@dpdk.org; Lu, Wenzhuo > > Subject: Re: [RFC] net/ixgbe: fix Tx descriptor status api > > Hi Wei, > > On Tue, Jun 26, 2018

Re: [dpdk-dev] [RFC] net/ixgbe: fix Tx descriptor status api

2018-06-26 Thread Zhao1, Wei
Hi, Olivier Matz > -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Tuesday, June 26, 2018 4:46 PM > To: Zhao1, Wei > Cc: Zhang, Qi Z ; dev@dpdk.org; Lu, Wenzhuo > > Subject: Re: [RFC] net/ixgbe: fix Tx descriptor status api > > Hi Wei, > > On Tue, Jun 26

Re: [dpdk-dev] [RFC] net/ixgbe: fix Tx descriptor status api

2018-06-26 Thread Olivier Matz
Hi Wei, On Tue, Jun 26, 2018 at 01:38:22AM +, Zhao1, Wei wrote: > Hi, Olivier Matz > > Will you commit fix patch for i40e and ixgbe and em? If you think the patch are relevant, yes :) Here is a pre-version (last 5 patches): http://git.droids-corp.org/?p=dpdk.git;a=shortlog;h=refs/heads/tx

Re: [dpdk-dev] [RFC] net/ixgbe: fix Tx descriptor status api

2018-06-25 Thread Zhao1, Wei
Hi, Olivier Matz Will you commit fix patch for i40e and ixgbe and em? And the code " dd = (desc / txq->tx_rs_thresh + 1) * txq->tx_rs_thresh - 1;" Is only proper for tx function ixgbe_xmit_pkts_simple and ixgbe_xmit_pkts_vec (). But not proper for ixgbe_xmit_pkts (), the RS bit set rule is dif

Re: [dpdk-dev] [RFC] net/ixgbe: fix Tx descriptor status api

2018-06-25 Thread Olivier Matz
Removing wrong mails from the To and Cc. Sorry. On Mon, Jun 25, 2018 at 04:20:57PM +0200, Olivier Matz wrote: > The Tx descriptor status api was not behaving as expected. This API is > used to inspect the content of the descriptors in the Tx ring to > determine the length of the Tx queue. > > Sin

[dpdk-dev] [RFC] net/ixgbe: fix Tx descriptor status api

2018-06-25 Thread Olivier Matz
The Tx descriptor status api was not behaving as expected. This API is used to inspect the content of the descriptors in the Tx ring to determine the length of the Tx queue. Since the software advances the tail pointer and the hardware advances the head pointer, the Tx queue is located before txq-