Re: [dpdk-dev] [RFC] mlx5: fix error unwind in device start

2018-08-14 Thread Shahaf Shuler
Monday, August 13, 2018 6:21 PM, Stephen Hemminger: > Subject: Re: [RFC] mlx5: fix error unwind in device start > > The issue was caused in an early version of netvsc VF support where it forgot > to call dev_configure on the mlx5 device. In that case mlx5 would get > confused and stuck. I see, we

Re: [dpdk-dev] [RFC] mlx5: fix error unwind in device start

2018-08-13 Thread Stephen Hemminger
On Mon, 13 Aug 2018 07:52:47 + Shahaf Shuler wrote: > Hi Stephan, > > Thursday, August 2, 2018 1:00 AM, Stephen Hemminger: > > Subject: [RFC] mlx5: fix error unwind in device start > > > > The error handling in start of the mlx5 driver is buggy. > > For example, if setting up the flows fail

Re: [dpdk-dev] [RFC] mlx5: fix error unwind in device start

2018-08-13 Thread Shahaf Shuler
Hi Stephan, Thursday, August 2, 2018 1:00 AM, Stephen Hemminger: > Subject: [RFC] mlx5: fix error unwind in device start > > The error handling in start of the mlx5 driver is buggy. > For example, if setting up the flows fails the device driver will then get > stuck > in mlx5_flow_rxq_flags_clea

[dpdk-dev] [RFC] mlx5: fix error unwind in device start

2018-08-01 Thread Stephen Hemminger
The error handling in start of the mlx5 driver is buggy. For example, if setting up the flows fails the device driver will then get stuck in mlx5_flow_rxq_flags_clear waiting for something that will never happen. The problem is that the code jumps to a common error label and does unwind for portio