Re: [dpdk-dev] [RFC] kni: remove ethtool support

On 2/18/2019 1:07 PM, Igor Ryzhov wrote: > Hi Ferruh, > > Thanks. Should I be a maintainer to ack the patch? No, everyone can (n)ack a patch, though maintainers have more weight. > > Best regards, > Igor > > On Mon, Feb 18, 2019 at 3:33 PM Ferruh Yigit > wrote:

Re: [dpdk-dev] [RFC] kni: remove ethtool support

Hi Ferruh, Thanks. Should I be a maintainer to ack the patch? Best regards, Igor On Mon, Feb 18, 2019 at 3:33 PM Ferruh Yigit wrote: > On 2/6/2019 1:12 PM, Igor Ryzhov wrote: > > Hi Ferruh, > > > > What's the plan with this patch? > > Hi Igor, > > I just sent a deprecation notice for this: > h

Re: [dpdk-dev] [RFC] kni: remove ethtool support

On 2/6/2019 1:12 PM, Igor Ryzhov wrote: > Hi Ferruh, > > What's the plan with this patch? Hi Igor, I just sent a deprecation notice for this: https://patches.dpdk.org/patch/50347/ If the deprecation notice approved, requires 3 acks, note will go into 19.05 And later this patch can go in 19.08

Re: [dpdk-dev] [RFC] kni: remove ethtool support

Hi Ferruh, What's the plan with this patch? Best regards, Igor On Sat, Jan 5, 2019 at 7:55 PM Igor Ryzhov wrote: > Hi Ferruh, > > I answered in another thread. > > Regarding this patch – I have no objections now. > > Best regards, > Igor > > On Tue, Dec 18, 2018 at 9:17 PM Ferruh Yigit > wrot

Re: [dpdk-dev] [RFC] kni: remove ethtool support

Hi Ferruh, I answered in another thread. Regarding this patch – I have no objections now. Best regards, Igor On Tue, Dec 18, 2018 at 9:17 PM Ferruh Yigit wrote: > On 12/18/2018 9:20 AM, Ferruh Yigit wrote: > > On 12/18/2018 8:20 AM, Igor Ryzhov wrote: > >> Hi Ferruh, > >> > >> Please, look at

Re: [dpdk-dev] [RFC] kni: remove ethtool support

On 12/18/2018 9:20 AM, Ferruh Yigit wrote: > On 12/18/2018 8:20 AM, Igor Ryzhov wrote: >> Hi Ferruh, >> >> Please, look at my patch http://patches.dpdk.org/patch/48454/ and consider >> rebasing your patch over mine. > > Sorry about that, yes I will check it today. Hi Igor, I put some comments on

Re: [dpdk-dev] [RFC] kni: remove ethtool support

On 12/18/2018 8:20 AM, Igor Ryzhov wrote: > Hi Ferruh, > > Please, look at my patch http://patches.dpdk.org/patch/48454/ and consider > rebasing your patch over mine. Sorry about that, yes I will check it today. > > As we discussed with Stephen, KNI needs to supply ethtool_ops with > .get_link

Re: [dpdk-dev] [RFC] kni: remove ethtool support

Hi Ferruh, Please, look at my patch http://patches.dpdk.org/patch/48454/ and consider rebasing your patch over mine. As we discussed with Stephen, KNI needs to supply ethtool_ops with .get_link function, to properly support link status. So we should save ethtool_ops and implement .get_link using