Re: [dpdk-dev] [RFC] ethdev: add new offload flag to keep CRC

2018-06-19 Thread Ferruh Yigit
On 6/11/2018 4:25 PM, Stephen Hemminger wrote: > On Fri, 8 Jun 2018 23:57:09 +0100 > Ferruh Yigit wrote: > >> DEV_RX_OFFLOAD_KEEP_CRC offload flag added. >> >> DEV_RX_OFFLOAD_CRC_STRIP flag will remain one more release >> default behavior in PMDs is to keep the CRC until this flag removed > > T

Re: [dpdk-dev] [RFC] ethdev: add new offload flag to keep CRC

2018-06-11 Thread Stephen Hemminger
On Fri, 8 Jun 2018 23:57:09 +0100 Ferruh Yigit wrote: > DEV_RX_OFFLOAD_KEEP_CRC offload flag added. > > DEV_RX_OFFLOAD_CRC_STRIP flag will remain one more release > default behavior in PMDs is to keep the CRC until this flag removed This won't work for virtual devices that never keep CRC. Mayb

Re: [dpdk-dev] [RFC] ethdev: add new offload flag to keep CRC

2018-06-11 Thread Ferruh Yigit
On 6/9/2018 11:11 AM, Andrew Rybchenko wrote: > On 06/09/2018 01:57 AM, Ferruh Yigit wrote: >> DEV_RX_OFFLOAD_KEEP_CRC offload flag added. >> >> DEV_RX_OFFLOAD_CRC_STRIP flag will remain one more release >> default behavior in PMDs is to keep the CRC until this flag removed >> >> Until DEV_RX_OFFLO

Re: [dpdk-dev] [RFC] ethdev: add new offload flag to keep CRC

2018-06-09 Thread Andrew Rybchenko
On 06/09/2018 01:57 AM, Ferruh Yigit wrote: DEV_RX_OFFLOAD_KEEP_CRC offload flag added. DEV_RX_OFFLOAD_CRC_STRIP flag will remain one more release default behavior in PMDs is to keep the CRC until this flag removed Until DEV_RX_OFFLOAD_CRC_STRIP flag is removed: - Setting both KEEP_CRC & CRC_ST

[dpdk-dev] [RFC] ethdev: add new offload flag to keep CRC

2018-06-08 Thread Ferruh Yigit
DEV_RX_OFFLOAD_KEEP_CRC offload flag added. DEV_RX_OFFLOAD_CRC_STRIP flag will remain one more release default behavior in PMDs is to keep the CRC until this flag removed Until DEV_RX_OFFLOAD_CRC_STRIP flag is removed: - Setting both KEEP_CRC & CRC_STRIP is INVALID - Setting only CRC_STRIP PMD sh