Re: [dpdk-dev] [RFC] ethdev: add min/max MTU to device info

2019-06-24 Thread Nithin Kumar Dabilpuram
ndrew Rybchenko Subject: Re: [dpdk-dev] [RFC] ethdev: add min/max MTU to device info On 2/7/2019 12:00 PM, Ananyev, Konstantin wrote: > >>> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, >>> Konstantin >>>> >>>>> From: dev on beha

Re: [dpdk-dev] [RFC] ethdev: add min/max MTU to device info

2019-02-20 Thread Ian Stokes
On 2/7/2019 12:00 PM, Ananyev, Konstantin wrote: From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, Konstantin From: dev on behalf of Stephen Hemminger On Wed, 6 Feb 2019 14:05:34 +0100 Morten Brørup wrote: Good work, Stephen. It should also be documented how PMDs should inter

Re: [dpdk-dev] [RFC] ethdev: add min/max MTU to device info

2019-02-07 Thread Ananyev, Konstantin
> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, > > Konstantin > > > > > > > From: dev on behalf of Stephen Hemminger > > > > On Wed, 6 Feb 2019 14:05:34 +0100 > > > > Morten Brørup wrote: > > > > > > > > > Good work, Stephen. > > > > > > > > > > It should also be documented how

Re: [dpdk-dev] [RFC] ethdev: add min/max MTU to device info

2019-02-07 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, > Konstantin > > > > > From: dev on behalf of Stephen Hemminger > > > On Wed, 6 Feb 2019 14:05:34 +0100 > > > Morten Brørup wrote: > > > > > > > Good work, Stephen. > > > > > > > > It should also be documented how PMDs should interpre

Re: [dpdk-dev] [RFC] ethdev: add min/max MTU to device info

2019-02-07 Thread Ananyev, Konstantin
> > > From: dev on behalf of Stephen Hemminger > > On Wed, 6 Feb 2019 14:05:34 +0100 > > Morten Brørup wrote: > > > > > Good work, Stephen. > > > > > > It should also be documented how PMDs should interpret this MTU. > > > > > > Obviously, a VLAN tagged Ethernet frame grows from 1518 to 1522 b

Re: [dpdk-dev] [RFC] ethdev: add min/max MTU to device info

2019-02-06 Thread Morten Brørup
> From: dev on behalf of Stephen Hemminger > On Wed, 6 Feb 2019 14:05:34 +0100 > Morten Brørup wrote: > > > Good work, Stephen. > > > > It should also be documented how PMDs should interpret this MTU. > > > > Obviously, a VLAN tagged Ethernet frame grows from 1518 to 1522 bytes incl. > > heade

Re: [dpdk-dev] [RFC] ethdev: add min/max MTU to device info

2019-02-06 Thread Stephen Hemminger
On Wed, 6 Feb 2019 14:05:34 +0100 Morten Brørup wrote: > Good work, Stephen. > > It should also be documented how PMDs should interpret this MTU. > > Obviously, a VLAN tagged Ethernet frame grows from 1518 to 1522 bytes incl. > header and CRC, and should be allowed with an Ethernet MTU of 1500

Re: [dpdk-dev] [RFC] ethdev: add min/max MTU to device info

2019-02-06 Thread Morten Brørup
Good work, Stephen. It should also be documented how PMDs should interpret this MTU. Obviously, a VLAN tagged Ethernet frame grows from 1518 to 1522 bytes incl. header and CRC, and should be allowed with an Ethernet MTU of 1500 bytes. There's even a #define ETHER_MAX_VLAN_FRAME_LEN for this, bu

Re: [dpdk-dev] [RFC] ethdev: add min/max MTU to device info

2019-01-16 Thread Stephen Hemminger
On Wed, 19 Dec 2018 03:37:16 +0100 Thomas Monjalon wrote: > Hi Stephen, > > Can we expect a v2 of this patch? At least for removing deprecation > and bump ethdev version, etc? > > 05/09/2018 18:41, Stephen Hemminger: > > This addresses the usability issue raised by OVS at DPDK Userspace > > sum

Re: [dpdk-dev] [RFC] ethdev: add min/max MTU to device info

2018-12-18 Thread Thomas Monjalon
Hi Stephen, Can we expect a v2 of this patch? At least for removing deprecation and bump ethdev version, etc? 05/09/2018 18:41, Stephen Hemminger: > This addresses the usability issue raised by OVS at DPDK Userspace > summit. It adds general min/max mtu into device info. For compatiablity, > and

Re: [dpdk-dev] [RFC] ethdev: add min/max MTU to device info

2018-11-22 Thread Stokes, Ian
> On Thu, 6 Sep 2018 09:29:32 +0300 > Andrew Rybchenko wrote: > > > On 09/05/2018 07:41 PM, Stephen Hemminger wrote: > > > This addresses the usability issue raised by OVS at DPDK Userspace > > > summit. It adds general min/max mtu into device info. For > > > compatiablity, and to save space, it

Re: [dpdk-dev] [RFC] ethdev: add min/max MTU to device info

2018-09-06 Thread Stephen Hemminger
On Thu, 6 Sep 2018 09:29:32 +0300 Andrew Rybchenko wrote: > On 09/05/2018 07:41 PM, Stephen Hemminger wrote: > > This addresses the usability issue raised by OVS at DPDK Userspace > > summit. It adds general min/max mtu into device info. For compatiablity, > > and to save space, it fits in a hole

Re: [dpdk-dev] [RFC] ethdev: add min/max MTU to device info

2018-09-05 Thread Andrew Rybchenko
On 09/05/2018 07:41 PM, Stephen Hemminger wrote: This addresses the usability issue raised by OVS at DPDK Userspace summit. It adds general min/max mtu into device info. For compatiablity, and to save space, it fits in a hole in existing structure. It is true for amd64, but it looks like it is

Re: [dpdk-dev] [RFC] ethdev: add min/max MTU to device info

2018-09-05 Thread Shahaf Shuler
Wednesday, September 5, 2018 7:42 PM, Stephen Hemminger: > Subject: [dpdk-dev] [RFC] ethdev: add min/max MTU to device info > > This addresses the usability issue raised by OVS at DPDK Userspace summit. > It adds general min/max mtu into device info. For compatiablity, and to save

[dpdk-dev] [RFC] ethdev: add min/max MTU to device info

2018-09-05 Thread Stephen Hemminger
This addresses the usability issue raised by OVS at DPDK Userspace summit. It adds general min/max mtu into device info. For compatiablity, and to save space, it fits in a hole in existing structure. The initial version sets max mtu to normal Ethernet, it is up to PMD to set larger value if it sup