Re: [dpdk-dev] [RFC] ethdev: add VLAN attributes to ETH item

2020-09-07 Thread Dekel Peled
> Subject: Re: [dpdk-dev] [RFC] ethdev: add VLAN attributes to ETH item > > Hi Dekel, > > First, I don't understand the initial change [1] done on RTE_FLOW API. As [1] commit log specifies, it is meant to clarify the required pattern to use, and reduce ambiguity. > B

Re: [dpdk-dev] [RFC] ethdev: add VLAN attributes to ETH item

2020-09-07 Thread Maxime Leroy
Hi Dekel, First, I don't understand the initial change [1] done on RTE_FLOW API. Before this change, it was possible to match any packets with or without vlan encapsulations. At least, it's not anymore the case with the mlx5 pmd. For example, if I want to match any ssh packets whatever if it's en

Re: [dpdk-dev] [RFC] ethdev: add VLAN attributes to ETH item

2020-08-06 Thread Eli Britstein
On 8/4/2020 6:36 PM, Dekel Peled wrote: In existing code the match on tagged/untagged packets is not explicit. Recent documentation update [1] describes the different patterns and clarifies the intended use of different patterns. This patch proposes an update to ETH item struct, to clearly def

Re: [dpdk-dev] [RFC] ethdev: add VLAN attributes to ETH item

2020-08-05 Thread Matan Azrad
But if the user want to force only one vlan and don't care about others? > -Original Message- > From: Dekel Peled > Sent: Wednesday, August 5, 2020 9:54 AM > To: Eli Britstein ; ferruh.yi...@intel.com; > arybche...@solarflare.com; Ori Kam ; Thomas > Monjalon > Cc: Asaf Penso ; Matan Azr

Re: [dpdk-dev] [RFC] ethdev: add VLAN attributes to ETH item

2020-08-04 Thread Dekel Peled
Thanks, PSB. > -Original Message- > From: Eli Britstein > Sent: Tuesday, August 4, 2020 6:47 PM > To: Dekel Peled ; ferruh.yi...@intel.com; > arybche...@solarflare.com; Ori Kam ; Thomas > Monjalon > Cc: Asaf Penso ; Matan Azrad > ; dev@dpdk.org > Subject: Re: [RFC] ethdev: add VLAN attri

Re: [dpdk-dev] [RFC] ethdev: add VLAN attributes to ETH item

2020-08-04 Thread Dekel Peled
org > Subject: Re: [dpdk-dev] [RFC] ethdev: add VLAN attributes to ETH item > > On Tue, 4 Aug 2020 18:36:20 +0300 > Dekel Peled wrote: > > > In existing code the match on tagged/untagged packets is not explicit. > > Recent documentation update [1] describes the diffe

Re: [dpdk-dev] [RFC] ethdev: add VLAN attributes to ETH item

2020-08-04 Thread Stephen Hemminger
On Tue, 4 Aug 2020 18:36:20 +0300 Dekel Peled wrote: > In existing code the match on tagged/untagged packets is not explicit. > Recent documentation update [1] describes the different patterns and > clarifies the intended use of different patterns. > > This patch proposes an update to ETH item

[dpdk-dev] [RFC] ethdev: add VLAN attributes to ETH item

2020-08-04 Thread Dekel Peled
In existing code the match on tagged/untagged packets is not explicit. Recent documentation update [1] describes the different patterns and clarifies the intended use of different patterns. This patch proposes an update to ETH item struct, to clearly define the required characteristic of a packet,