Re: [dpdk-dev] [RFC] cryptodev: proposed changes in rte_cryptodev_sym_session

2018-11-14 Thread Zhang, Roy Fan
Hi Fiona, > -Original Message- > From: Trahe, Fiona > Sent: Wednesday, November 14, 2018 12:46 AM > To: Ananyev, Konstantin ; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Akhil Goyal > ; Doherty, Declan ; Ravi > Kumar ; Jerin Jacob > ; Zhang, Roy Fan > ; Tomasz Duszynski ; > Hemant Agrawal ;

Re: [dpdk-dev] [RFC] cryptodev: proposed changes in rte_cryptodev_sym_session

2018-11-14 Thread Ananyev, Konstantin
> > > > @@ -1301,8 +1346,7 @@ rte_cryptodev_sym_session_free(struct > > > > rte_cryptodev_sym_session *sess) > > > > > > > > /* Check that all device private data has been freed */ > > > > for (i = 0; i < nb_drivers; i++) { > > > [Fiona] Use the sess.nb_drivers rather than the gl

Re: [dpdk-dev] [RFC] cryptodev: proposed changes in rte_cryptodev_sym_session

2018-11-13 Thread Trahe, Fiona
Hi Konstantin, //snip/// > Can you also have a look at related deprecation note: > http://patches.dpdk.org/patch/46633/ > and provide the feedback? > Konstantin [Fiona] will do > > [Fiona] Ok, I agree with this issue and proposed fix. > > We need to also document that it's user's responsibilit

Re: [dpdk-dev] [RFC] cryptodev: proposed changes in rte_cryptodev_sym_session

2018-11-13 Thread Ananyev, Konstantin
> -Original Message- > From: Trahe, Fiona > Sent: Monday, November 12, 2018 11:25 PM > To: Ananyev, Konstantin ; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Akhil Goyal > ; Doherty, Declan > ; Ravi Kumar ; Jerin Jacob > ; Zhang, Roy Fan > ; Tomasz Duszynski ; Hemant > Agrawal ; Natalie

Re: [dpdk-dev] [RFC] cryptodev: proposed changes in rte_cryptodev_sym_session

2018-11-13 Thread Ananyev, Konstantin
Hi Fiona, > -Original Message- > From: Trahe, Fiona > Sent: Monday, November 12, 2018 9:01 PM > To: Ananyev, Konstantin ; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Akhil Goyal > ; Doherty, Declan > ; Ravi Kumar ; Jerin Jacob > ; Zhang, Roy Fan > ; Tomasz Duszynski ; Hemant > Agrawal ;

Re: [dpdk-dev] [RFC] cryptodev: proposed changes in rte_cryptodev_sym_session

2018-11-12 Thread Trahe, Fiona
Correction below > -Original Message- > From: Trahe, Fiona > Sent: Monday, November 12, 2018 4:17 PM > To: Ananyev, Konstantin ; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Akhil Goyal > ; > Doherty, Declan ; Ravi Kumar ; > Jerin Jacob > ; Zhang, Roy Fan ; > Tomasz Duszynski > ; Hemant A

Re: [dpdk-dev] [RFC] cryptodev: proposed changes in rte_cryptodev_sym_session

2018-11-12 Thread Trahe, Fiona
RE item 4: use of session pool in qp setup: > > 4.#2 and #3 above implies that now each struct rte_cryptodev_sym_session > > would have sort of readonly type data (init once at allocation time, > > keep unmodified through session life-time). > > That requires more changes in current cryptodev

Re: [dpdk-dev] [RFC] cryptodev: proposed changes in rte_cryptodev_sym_session

2018-11-12 Thread Trahe, Fiona
Hi Konstantin, Sorry for the delay in reviewing this and thanks for your proposals. > -Original Message- > From: Ananyev, Konstantin > Sent: Friday, August 24, 2018 10:48 AM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; De Lara Guarch, Pablo > ; Akhil Goyal ; Doherty, > Declan > ; Ravi K

Re: [dpdk-dev] [RFC] cryptodev: proposed changes in rte_cryptodev_sym_session

2018-10-05 Thread Ananyev, Konstantin
Hi everyone, > This RFC for proposes several changes inside rte_cryptodev_sym_session. > Note that this is just RFC not a complete patch, so for now > I modified only the librte_cryptodev itself, > some cryptodev PMD, test-crypto-perf and ipsec-secgw example. > Proposed changes means ABI/API break

[dpdk-dev] [RFC] cryptodev: proposed changes in rte_cryptodev_sym_session

2018-08-24 Thread Konstantin Ananyev
This RFC for proposes several changes inside rte_cryptodev_sym_session. Note that this is just RFC not a complete patch, so for now I modified only the librte_cryptodev itself, some cryptodev PMD, test-crypto-perf and ipsec-secgw example. Proposed changes means ABI/API breakage inside cryptodev, so