Re: [dpdk-dev] [RFC] cmdline: rework as a wrapper to libedit

2017-11-16 Thread Thomas Monjalon
16/11/2017 17:48, Wiles, Keith: > For now we can accept your patch for cmdline as it does add the support > without much effort. I agree.

Re: [dpdk-dev] [RFC] cmdline: rework as a wrapper to libedit

2017-11-16 Thread Thomas Monjalon
16/11/2017 18:27, Wiles, Keith: > > > On Nov 16, 2017, at 9:06 AM, Yigit, Ferruh wrote: > > > > On 11/16/2017 1:23 AM, Adrien Mazarguil wrote: > > <...> > > > >>> I do not agree it has severed DPDK well, just look at test-pmd and the > >>> hoops people have to jump thru to get a new command or

Re: [dpdk-dev] [RFC] cmdline: rework as a wrapper to libedit

2017-11-16 Thread Wiles, Keith
> On Nov 16, 2017, at 9:06 AM, Yigit, Ferruh wrote: > > On 11/16/2017 1:23 AM, Adrien Mazarguil wrote: > <...> > >>> I do not agree it has severed DPDK well, just look at test-pmd and the >>> hoops people have to jump thru to get a new command or variation of an >>> existing command integrat

Re: [dpdk-dev] [RFC] cmdline: rework as a wrapper to libedit

2017-11-16 Thread Ferruh Yigit
On 11/16/2017 1:23 AM, Adrien Mazarguil wrote: <...> >> I do not agree it has severed DPDK well, just look at test-pmd and the hoops >> people have to jump thru to get a new command or variation of an existing >> command integrated into test-pmd it is very difficult. Also if you look at >> the

Re: [dpdk-dev] [RFC] cmdline: rework as a wrapper to libedit

2017-11-16 Thread Wiles, Keith
> On Nov 16, 2017, at 1:23 AM, Adrien Mazarguil > wrote: > > Hi Keith, > > On Wed, Nov 15, 2017 at 04:12:07AM +, Wiles, Keith wrote: >> >> >>> On Nov 9, 2017, at 5:43 AM, Adrien Mazarguil >>> wrote: >>> >>> This patch removes all code associated with symbols not internally relied >>>

Re: [dpdk-dev] [RFC] cmdline: rework as a wrapper to libedit

2017-11-16 Thread Adrien Mazarguil
Hi Keith, On Wed, Nov 15, 2017 at 04:12:07AM +, Wiles, Keith wrote: > > > > On Nov 9, 2017, at 5:43 AM, Adrien Mazarguil > > wrote: > > > > This patch removes all code associated with symbols not internally relied > > on by other DPDK components, makes struct cmdline opaque and then proce

Re: [dpdk-dev] [RFC] cmdline: rework as a wrapper to libedit

2017-11-15 Thread Wiles, Keith
> On Nov 15, 2017, at 12:04 AM, Olivier MATZ wrote: > > Hi, > > On Wed, Nov 15, 2017 at 04:12:07AM +, Wiles, Keith wrote: >> >> >>> On Nov 9, 2017, at 5:43 AM, Adrien Mazarguil >>> wrote: >>> >>> This patch removes all code associated with symbols not internally relied >>> on by other

Re: [dpdk-dev] [RFC] cmdline: rework as a wrapper to libedit

2017-11-15 Thread Olivier MATZ
Hi, On Wed, Nov 15, 2017 at 04:12:07AM +, Wiles, Keith wrote: > > > > On Nov 9, 2017, at 5:43 AM, Adrien Mazarguil > > wrote: > > > > This patch removes all code associated with symbols not internally relied > > on by other DPDK components, makes struct cmdline opaque and then proceeds >

Re: [dpdk-dev] [RFC] cmdline: rework as a wrapper to libedit

2017-11-14 Thread Wiles, Keith
> On Nov 9, 2017, at 5:43 AM, Adrien Mazarguil > wrote: > > This patch removes all code associated with symbols not internally relied > on by other DPDK components, makes struct cmdline opaque and then proceeds > to re-implement the remaining functionality as a wrapper to the editline > librar

[dpdk-dev] [RFC] cmdline: rework as a wrapper to libedit

2017-11-09 Thread Adrien Mazarguil
This patch removes all code associated with symbols not internally relied on by other DPDK components, makes struct cmdline opaque and then proceeds to re-implement the remaining functionality as a wrapper to the editline library (also known as libedit) [1]. Besides adding a new external dependenc