Re: [dpdk-dev] [RFC] New packet type query API

2018-02-05 Thread Adrien Mazarguil
On Tue, Jan 23, 2018 at 02:46:19AM +, Yang, Qiming wrote: > Sorry for reply so late. Answered in line. Same for me, please see below. > > > This flag will be configured in dev_configure(), and can be queried by > > > user > > through dev->data->dev_conf.rxmode.enable_ptype_direct. In receiv

Re: [dpdk-dev] [RFC] New packet type query API

2018-01-22 Thread Yang, Qiming
> -Original Message- > From: Shahaf Shuler [mailto:shah...@mellanox.com] > Sent: Wednesday, January 17, 2018 10:34 PM > To: Andrew Rybchenko ; Adrien Mazarguil > ; Yang, Qiming > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [RFC] New packet type query API > > Wed

Re: [dpdk-dev] [RFC] New packet type query API

2018-01-22 Thread Yang, Qiming
Answered in adrien’s email. From: Andrew Rybchenko [mailto:arybche...@solarflare.com] Sent: Wednesday, January 17, 2018 4:09 PM To: Adrien Mazarguil ; Yang, Qiming Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [RFC] New packet type query API On 01/16/2018 06:55 PM, Adrien Mazarguil wrote: I

Re: [dpdk-dev] [RFC] New packet type query API

2018-01-22 Thread Yang, Qiming
Sorry for reply so late. Answered in line. > > This flag will be configured in dev_configure(), and can be queried by user > through dev->data->dev_conf.rxmode.enable_ptype_direct. In receive function, > driver will store HW's packet type value in mbuf->packet_type if direct mode > is > enabled,

Re: [dpdk-dev] [RFC] New packet type query API

2018-01-17 Thread Shahaf Shuler
Wednesday, January 17, 2018 10:09 AM, Andrew RybchenkoL > On 01/16/2018 06:55 PM, Adrien Mazarguil wrote: > > I understand the motivation behind this proposal, however since new > > ideas must be challenged, I have a few comments: > > > > - How about making packet type recognition an optional offlo

Re: [dpdk-dev] [RFC] New packet type query API

2018-01-17 Thread Andrew Rybchenko
On 01/16/2018 06:55 PM, Adrien Mazarguil wrote: I understand the motivation behind this proposal, however since new ideas must be challenged, I have a few comments: - How about making packet type recognition an optional offload configurable per queue like any other (e.g. DEV_RX_OFFLOAD_PTYPE)

Re: [dpdk-dev] [RFC] New packet type query API

2018-01-16 Thread Adrien Mazarguil
On Fri, Jan 12, 2018 at 12:04:05AM +0800, Qiming Yang wrote: > This RFC contains a proposal to add a new packet type query API to DPDK. > > Motivation > == > In current DPDK implementation, when received one packet, driver will lookup > the packet type mapping table and transmit the resu

[dpdk-dev] [RFC] New packet type query API

2018-01-11 Thread Qiming Yang
This RFC contains a proposal to add a new packet type query API to DPDK. Motivation == In current DPDK implementation, when received one packet, driver will lookup the packet type mapping table and transmit the result value to struct mbuf. Appilcation will analyze the mbuf->packet_type