[dpdk-dev] [dpdk-dev, PATCHv5, 1/8] ethdev: add new API to retrieve RX/TX queue information

2015-10-20 Thread Vincent JARDIN
On 20/10/2015 09:53, Qiu, Michael wrote: > But as I know it is different all the time, am I right? > If yes, I don't know what's the value of this field. It can be used to get some snapshot/instant view informations while we have to monitor and debug.

[dpdk-dev] [dpdk-dev, PATCHv5, 1/8] ethdev: add new API to retrieve RX/TX queue information

2015-10-20 Thread Qiu, Michael
On 2015/10/20 16:09, Vincent JARDIN wrote: > On 20/10/2015 09:53, Qiu, Michael wrote: >> But as I know it is different all the time, am I right? >> If yes, I don't know what's the value of this field. > It can be used to get some snapshot/instant view informations while we > have to monitor and de

[dpdk-dev] [dpdk-dev, PATCHv5, 1/8] ethdev: add new API to retrieve RX/TX queue information

2015-10-20 Thread Qiu, Michael
Re: [dpdk-dev, PATCHv5, 1/8] ethdev: add new API to retrieve RX/TX >> queue information >> >> >> >> Hi Konstantin >>> +/** >>> + * Ethernet device RX queue information structure. >>> + * Used to retieve information about configured queue. >

[dpdk-dev] [PATCHv5 1/8] ethdev: add new API to retrieve RX/TX queue information

2015-10-16 Thread Bruce Richardson
dpdk.org > > Subject: Re: [dpdk-dev] [PATCHv5 1/8] ethdev: add new API to retrieve RX/TX > > queue information > > > > On Thu, 1 Oct 2015 20:54:46 +0100 > > Konstantin Ananyev wrote: > > > > > + if (nb_rx_desc > dev_info.rx

[dpdk-dev] [PATCHv5 1/8] ethdev: add new API to retrieve RX/TX queue information

2015-10-14 Thread Ananyev, Konstantin
> -Original Message- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Wednesday, October 14, 2015 5:09 PM > To: Ananyev, Konstantin > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCHv5 1/8] ethdev: add new API to retrieve RX/TX > queue in

[dpdk-dev] [dpdk-dev, PATCHv5, 1/8] ethdev: add new API to retrieve RX/TX queue information

2015-10-14 Thread Amine Kherbouche
> > So your v6 will make all implemented queue_info_get()s to fill these two new > fields correctly, right? > Konstantin Yes. Amine Kherbouche

[dpdk-dev] [dpdk-dev, PATCHv5, 1/8] ethdev: add new API to retrieve RX/TX queue information

2015-10-14 Thread Amine Kherbouche
Hi Konstantin > Well, in general I am not opposed to add these fields to the structures. > In fact, I think it is a good thing to have. > But if we'll add them without making queue_info_get() feeling them properly - > it might create a lot of controversy. > So unless you prepared to make changes

[dpdk-dev] [PATCHv5 1/8] ethdev: add new API to retrieve RX/TX queue information

2015-10-14 Thread Remy Horton
On 01/10/2015 20:54, Konstantin Ananyev wrote: > Signed-off-by: Konstantin Ananyev Acked-by: Remy Horton

[dpdk-dev] [dpdk-dev, PATCHv5, 1/8] ethdev: add new API to retrieve RX/TX queue information

2015-10-14 Thread Amine Kherbouche
Hi Konstantin > +/** > + * Ethernet device RX queue information structure. > + * Used to retieve information about configured queue. > + */ > +struct rte_eth_rxq_info { > + struct rte_mempool *mp; /**< mempool used by that queue. */ > + struct rte_eth_rxconf conf; /**< queue config pa

[dpdk-dev] [dpdk-dev, PATCHv5, 1/8] ethdev: add new API to retrieve RX/TX queue information

2015-10-14 Thread Ananyev, Konstantin
> -Original Message- > From: Amine Kherbouche [mailto:amine.kherbouche at 6wind.com] > Sent: Wednesday, October 14, 2015 1:47 PM > To: Ananyev, Konstantin; dev at dpdk.org > Subject: Re: [dpdk-dev, PATCHv5, 1/8] ethdev: add new API to retrieve RX/TX >

[dpdk-dev] [dpdk-dev, PATCHv5, 1/8] ethdev: add new API to retrieve RX/TX queue information

2015-10-14 Thread Ananyev, Konstantin
> -Original Message- > From: Amine Kherbouche [mailto:amine.kherbouche at 6wind.com] > Sent: Wednesday, October 14, 2015 1:22 PM > To: Ananyev, Konstantin; dev at dpdk.org > Subject: Re: [dpdk-dev, PATCHv5, 1/8] ethdev: add new API to retrieve RX/TX > queue info

[dpdk-dev] [dpdk-dev, PATCHv5, 1/8] ethdev: add new API to retrieve RX/TX queue information

2015-10-14 Thread Ananyev, Konstantin
Hi Amine, > -Original Message- > From: Amine Kherbouche [mailto:amine.kherbouche at 6wind.com] > Sent: Wednesday, October 14, 2015 12:40 PM > To: Ananyev, Konstantin; dev at dpdk.org > Subject: Re: [dpdk-dev, PATCHv5, 1/8] ethdev: add new API to retrieve RX/TX >

[dpdk-dev] [PATCHv5 1/8] ethdev: add new API to retrieve RX/TX queue information

2015-10-14 Thread Stephen Hemminger
On Thu, 1 Oct 2015 20:54:46 +0100 Konstantin Ananyev wrote: > + if (nb_rx_desc > dev_info.rx_desc_lim.nb_max || > + nb_rx_desc < dev_info.rx_desc_lim.nb_min || > + nb_rx_desc % dev_info.rx_desc_lim.nb_align != 0) { > + Preferred indentation style is t

[dpdk-dev] [PATCHv5 1/8] ethdev: add new API to retrieve RX/TX queue information

2015-10-01 Thread Konstantin Ananyev
From: "Ananyev, Konstantin" Add the ability for the upper layer to query RX/TX queue information. Add into rte_eth_dev_info new fields to represent information about RX/TX descriptors min/max/alig nnumbers per queue for the device. Add new structures: struct rte_eth_rxq_info struct rte_eth_txq_i