Re: [dpdk-dev] [PATCHv4 2/5] compat: Add __experimental macro

2018-01-21 Thread Thomas Monjalon
Hi, I know I should have spotted these comments earlier, I'm sorry to be late on this review. 13/12/2017 16:17, Neil Horman: > +#ifndef ALLOW_EXPERIMENTAL_APIS > > +#define __experimental \ These macros should be in the DPDK namespace: RTE_ALLOW_EXPERIMENTAL_API (no need of S)

[dpdk-dev] [PATCHv4 2/5] compat: Add __experimental macro

2017-12-13 Thread Neil Horman
The __experimental macro tags a given exported function as being part of the EXPERIMENTAL api. Use of this tag will cause any caller of the function (that isn't removed by dead code elimination) to emit a warning that the user is making use of an API whos stabilty isn't guaranteed. It also places