Re: [dpdk-dev] [PATCH v9 5/6] lib/hash: use ring with 32b element size to save memory

2020-01-17 Thread Wang, Yipeng1
>-Original Message- >> > Not sure how users could make use of this. >> > But the abi check flags this as a breakage since this type was exported. >> I think this is a false positive. >> >> Users include 'rte_hash.h' file which does not define the structure. It just >> has the declaration '

Re: [dpdk-dev] [PATCH v9 5/6] lib/hash: use ring with 32b element size to save memory

2020-01-17 Thread David Marchand
On Fri, Jan 17, 2020 at 9:54 PM Honnappa Nagarahalli wrote: > > > > > > > On Thu, Jan 16, 2020 at 6:25 AM Honnappa Nagarahalli > > wrote: > > > > > > The freelist and external bucket indices are 32b. Using rings that use > > > 32b element sizes will save memory. > > > > > > Signed-off-by: Honnap

Re: [dpdk-dev] [PATCH v9 5/6] lib/hash: use ring with 32b element size to save memory

2020-01-17 Thread Honnappa Nagarahalli
> > On Thu, Jan 16, 2020 at 6:25 AM Honnappa Nagarahalli > wrote: > > > > The freelist and external bucket indices are 32b. Using rings that use > > 32b element sizes will save memory. > > > > Signed-off-by: Honnappa Nagarahalli > > Reviewed-by: Gavin Hu > > Reviewed-by: Ola Liljedahl > > --

Re: [dpdk-dev] [PATCH v9 5/6] lib/hash: use ring with 32b element size to save memory

2020-01-17 Thread David Marchand
On Thu, Jan 16, 2020 at 6:25 AM Honnappa Nagarahalli wrote: > > The freelist and external bucket indices are 32b. Using rings > that use 32b element sizes will save memory. > > Signed-off-by: Honnappa Nagarahalli > Reviewed-by: Gavin Hu > Reviewed-by: Ola Liljedahl > --- > lib/librte_hash/rte_

[dpdk-dev] [PATCH v9 5/6] lib/hash: use ring with 32b element size to save memory

2020-01-15 Thread Honnappa Nagarahalli
The freelist and external bucket indices are 32b. Using rings that use 32b element sizes will save memory. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu Reviewed-by: Ola Liljedahl --- lib/librte_hash/rte_cuckoo_hash.c | 94 --- lib/librte_hash/rte_cuckoo