Re: [dpdk-dev] [PATCH v9 2/6] lib/ring: apis to support configurable element size

2020-01-18 Thread Honnappa Nagarahalli
> > > > On Wed, Jan 15, 2020 at 11:25:07PM -0600, Honnappa Nagarahalli wrote: > > > > Current APIs assume ring elements to be pointers. However, in many > > > > use cases, the size can be different. Add new APIs to support > > > > configurable ring element sizes. > > > > > > > > Signed-off-by: H

Re: [dpdk-dev] [PATCH v9 2/6] lib/ring: apis to support configurable element size

2020-01-18 Thread Ananyev, Konstantin
> > On Wed, Jan 15, 2020 at 11:25:07PM -0600, Honnappa Nagarahalli wrote: > > > Current APIs assume ring elements to be pointers. However, in many use > > > cases, the size can be different. Add new APIs to support configurable > > > ring element sizes. > > > > > > Signed-off-by: Honnappa Nagarah

Re: [dpdk-dev] [PATCH v9 2/6] lib/ring: apis to support configurable element size

2020-01-17 Thread David Christensen
+static __rte_always_inline void +enqueue_elems_128(struct rte_ring *r, uint32_t prod_head, + const void *obj_table, uint32_t n) +{ + unsigned int i; + const uint32_t size = r->size; + uint32_t idx = prod_head & r->mask; + rte_int128_t *ring = (rte_int128_t *)

Re: [dpdk-dev] [PATCH v9 2/6] lib/ring: apis to support configurable element size

2020-01-17 Thread Honnappa Nagarahalli
> > Hi Honnappa, Thanks Olivier for your review, appreciate your feedback. > > On Wed, Jan 15, 2020 at 11:25:07PM -0600, Honnappa Nagarahalli wrote: > > Current APIs assume ring elements to be pointers. However, in many use > > cases, the size can be different. Add new APIs to support configur

Re: [dpdk-dev] [PATCH v9 2/6] lib/ring: apis to support configurable element size

2020-01-17 Thread Olivier Matz
Hi Honnappa, On Wed, Jan 15, 2020 at 11:25:07PM -0600, Honnappa Nagarahalli wrote: > Current APIs assume ring elements to be pointers. However, in many > use cases, the size can be different. Add new APIs to support > configurable ring element sizes. > > Signed-off-by: Honnappa Nagarahalli > Rev

[dpdk-dev] [PATCH v9 2/6] lib/ring: apis to support configurable element size

2020-01-15 Thread Honnappa Nagarahalli
Current APIs assume ring elements to be pointers. However, in many use cases, the size can be different. Add new APIs to support configurable ring element sizes. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Dharmik Thakkar Reviewed-by: Gavin Hu Reviewed-by: Ruifeng Wang --- lib/librte_rin