Re: [dpdk-dev] [PATCH v9] checkpatches.sh: Add checks for ABI symbol addition

2018-08-16 Thread Neil Horman
On Thu, Aug 16, 2018 at 06:19:40AM +, Rao, Nikhil wrote: > > > > -Original Message- > > From: Neil Horman [mailto:nhor...@tuxdriver.com] > > Sent: Wednesday, August 15, 2018 4:19 PM > > To: Rao, Nikhil > > Cc: dev@dpdk.org; tho...@monjalon.net; Mcnamara, John > > ; Richardson, Bruce

Re: [dpdk-dev] [PATCH v9] checkpatches.sh: Add checks for ABI symbol addition

2018-08-15 Thread Rao, Nikhil
> -Original Message- > From: Neil Horman [mailto:nhor...@tuxdriver.com] > Sent: Wednesday, August 15, 2018 4:19 PM > To: Rao, Nikhil > Cc: dev@dpdk.org; tho...@monjalon.net; Mcnamara, John > ; Richardson, Bruce > ; Yigit, Ferruh ; > step...@networkplumber.org; toggle-mailboxes@hmswarspi

Re: [dpdk-dev] [PATCH v9] checkpatches.sh: Add checks for ABI symbol addition

2018-08-15 Thread Neil Horman
On Wed, Aug 15, 2018 at 11:40:42AM +0530, Nikhil Rao wrote: > > -Original Message- > > From: Neil Horman [mailto:nhor...@tuxdriver.com] > > I was about to say that its because you've not got enough context to let the > > awk file figure out what your section name is, but that doesn't appear

Re: [dpdk-dev] [PATCH v9] checkpatches.sh: Add checks for ABI symbol addition

2018-08-14 Thread Nikhil Rao
> -Original Message- > From: Neil Horman [mailto:nhor...@tuxdriver.com] > I was about to say that its because you've not got enough context to let the > awk file figure out what your section name is, but that doesn't appear to be > the case. Can you provide the exact command line you are ru

Re: [dpdk-dev] [PATCH v9] checkpatches.sh: Add checks for ABI symbol addition

2018-08-14 Thread Neil Horman
On Tue, Aug 14, 2018 at 09:23:59AM +0530, Rao, Nikhil wrote: > On 6/27/2018 11:31 PM, Neil Horman wrote: > > diff --git a/devtools/check-symbol-change.sh > > b/devtools/check-symbol-change.sh > > new file mode 100755 > > index 0..17d123cf4 > > --- /dev/null > > +++ b/devtools/check-symbol-

Re: [dpdk-dev] [PATCH v9] checkpatches.sh: Add checks for ABI symbol addition

2018-08-13 Thread Rao, Nikhil
On 6/27/2018 11:31 PM, Neil Horman wrote: diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh new file mode 100755 index 0..17d123cf4 --- /dev/null +++ b/devtools/check-symbol-change.sh @@ -0,0 +1,159 @@ +#!/bin/sh +# SPDX-License-Identifier: BSD-3-Clause +# Cop

Re: [dpdk-dev] [PATCH v9] checkpatches.sh: Add checks for ABI symbol addition

2018-07-15 Thread Thomas Monjalon
27/06/2018 20:01, Neil Horman: > Recently, some additional patches were added to allow for programmatic > marking of C symbols as experimental. The addition of these markers is > dependent on the manual addition of exported symbols to the EXPERIMENTAL > section of the corresponding libraries versi

[dpdk-dev] [PATCH v9] checkpatches.sh: Add checks for ABI symbol addition

2018-06-27 Thread Neil Horman
Recently, some additional patches were added to allow for programmatic marking of C symbols as experimental. The addition of these markers is dependent on the manual addition of exported symbols to the EXPERIMENTAL section of the corresponding libraries version map file. The consensus on review i