Re: [dpdk-dev] [PATCH v8 7/7] igb_uio: fix uio release issue for hotplug

2018-07-11 Thread Jeff Guo
On 7/11/2018 10:46 AM, Jeff Guo wrote: On 7/11/2018 5:52 AM, Stephen Hemminger wrote: On Tue, 10 Jul 2018 19:03:27 +0800 Jeff Guo wrote: When hotplug out device, the device resource will be released in kernel. The fd sys file will disappear, and the irq will be released. At this time, i

Re: [dpdk-dev] [PATCH v8 7/7] igb_uio: fix uio release issue for hotplug

2018-07-10 Thread Jeff Guo
On 7/11/2018 5:48 AM, Stephen Hemminger wrote: On Tue, 10 Jul 2018 19:03:27 +0800 Jeff Guo wrote: +/* uio pci device state */ +enum rte_udev_state { + RTE_UDEV_PROBED, + RTE_UDEV_OPENNED, + RTE_UDEV_RELEASED, + RTE_UDEV_REMOVED, +}; + The states here are a little

Re: [dpdk-dev] [PATCH v8 7/7] igb_uio: fix uio release issue for hotplug

2018-07-10 Thread Jeff Guo
On 7/11/2018 5:52 AM, Stephen Hemminger wrote: On Tue, 10 Jul 2018 19:03:27 +0800 Jeff Guo wrote: When hotplug out device, the device resource will be released in kernel. The fd sys file will disappear, and the irq will be released. At this time, if igb uio driver still try to release this

Re: [dpdk-dev] [PATCH v8 7/7] igb_uio: fix uio release issue for hotplug

2018-07-10 Thread Stephen Hemminger
On Tue, 10 Jul 2018 19:03:27 +0800 Jeff Guo wrote: > When hotplug out device, the device resource will be released in kernel. > The fd sys file will disappear, and the irq will be released. At this time, > if igb uio driver still try to release this resource, it will cause kernel > crash. On the

Re: [dpdk-dev] [PATCH v8 7/7] igb_uio: fix uio release issue for hotplug

2018-07-10 Thread Stephen Hemminger
On Tue, 10 Jul 2018 19:03:27 +0800 Jeff Guo wrote: > > +/* uio pci device state */ > +enum rte_udev_state { > + RTE_UDEV_PROBED, > + RTE_UDEV_OPENNED, > + RTE_UDEV_RELEASED, > + RTE_UDEV_REMOVED, > +}; > + The states here are a little confusing. especially since pci_release see

[dpdk-dev] [PATCH v8 7/7] igb_uio: fix uio release issue for hotplug

2018-07-10 Thread Jeff Guo
When hotplug out device, the device resource will be released in kernel. The fd sys file will disappear, and the irq will be released. At this time, if igb uio driver still try to release this resource, it will cause kernel crash. On the other hand, interrupt disabling do not automatically be proce