23/06/2020 08:45, Tal Shnaiderman:
> > 22/06/2020 09:55, tal...@mellanox.com:
> > > +struct internal_config *
> > > +rte_eal_get_internal_configuration(void)
> > > +{
> > > + return &internal_config;
> > > +}
> >
> > This function should be private to EAL, no rte_ prefix.
>
> When creating the ne
> Subject: Re: [dpdk-dev] [PATCH v8 1/9] eal: move OS common functions to
> single file
>
> Can we reduce the scope in the title?
> This patch is about EAL config in general, so I would reword it to:
> eal: move OS common config objects
>
Agree, will change in v9.
&g
Can we reduce the scope in the title?
This patch is about EAL config in general,
so I would reword it to:
eal: move OS common config objects
22/06/2020 09:55, tal...@mellanox.com:
> +#include
> +
> +#include
> +#include
Local files, like eal_*, are usually included with "".
[...]
> +/
From: Tal Shnaiderman
Move common functions between Unix and Windows to eal_common_config.c.
Those functions are getter functions for IOVA,
configuration, Multi-process.
Move rte_config, internal_config, early_mem_config and runtime_dir
to be defined in the common file with getter functions.
R
4 matches
Mail list logo
